Summary: | Suggestion not displayed on the order receive page | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, m.de.rooy, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00,21.05.04,20.11.10
|
Circulation function: | |
Bug Depends on: | 5346, 23376 | ||
Bug Blocks: | |||
Attachments: |
Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page
Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page |
Description
Jonathan Druart
2021-08-19 10:34:31 UTC
Created attachment 123969 [details] [review] Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 occurrences have not been corrected. It causes a bug on the order receive page when the bib is linked with a suggestion. Test plan: Create an order from bib A, create a suggestion for purchase on bib A (OPAC) Receive the order. Without the patch: Notice the "Suggested by: (suggestion #)" With the patch you see the info of the suggester Created attachment 123979 [details] [review] Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 occurrences have not been corrected. It causes a bug on the order receive page when the bib is linked with a suggestion. Test plan: Create an order from bib A, create a suggestion for purchase on bib A (OPAC) Receive the order. Without the patch: Notice the "Suggested by: (suggestion #)" With the patch you see the info of the suggester Signed-off-by: David Nind <david@davidnind.com> Created attachment 124130 [details] [review] Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 occurrences have not been corrected. It causes a bug on the order receive page when the bib is linked with a suggestion. Test plan: Create an order from bib A, create a suggestion for purchase on bib A (OPAC) Receive the order. Without the patch: Notice the "Suggested by: (suggestion #)" With the patch you see the info of the suggester Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.04 Pushed to 20.11.x for 20.11.10 Missing dependencies for 20.05.x, it shouldn't be affected, no backport. |