Summary: | Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 | ||
---|---|---|---|
Product: | Koha | Reporter: | Mason James <mtj> |
Component: | Packaging | Assignee: | Mason James <mtj> |
Status: | Pushed to oldoldoldstable --- | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, jonathan.druart, kyle, mtj, nick, tomascohen, victor, wainuiwitikapark |
Version: | Main | Keywords: | rel_20_11_candidate, rel_21_05_candidate |
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.08,20.11.15
|
|
Circulation function: | |||
Attachments: |
Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16
Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 |
Description
Mason James
2021-08-31 04:04:35 UTC
Created attachment 124256 [details] [review] Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 to test... - apply patch - build package - confirm in about.pl that minimum versions are updated On a ktd:stretch root@kohadevbox:koha(master)$ pmvers Mojolicious::Plugin::OpenAPI 2.16 root@kohadevbox:koha(master)$ pmvers Mojolicious 8.12 root@kohadevbox:koha(master)$ pmvers JSON::Validator 3.14 root@kohadevbox:koha(master)$ pmvers YAML::XS 0.76 root@kohadevbox:koha(master)$ apt-cache policy libjson-validator-perl libjson-validator-perl: Installed: 3.25+dfsg-1+koha3 Candidate: 3.25+dfsg-1+koha3 Version table: *** 3.25+dfsg-1+koha3 500 500 http://debian.koha-community.org/koha-staging dev/main amd64 Packages 100 /var/lib/dpkg/status 0.92+dfsg-1 500 500 http://httpredir.debian.org/debian stretch/main amd64 Packages Why is JSON::Validator 3.14? (In reply to Jonathan Druart from comment #2) > Why is JSON::Validator 3.14? From IRC: mtj> Joubu: re your question on bz 28926, the package should really be called libjson-validator-perl_3.25+really3.14 Created attachment 126438 [details] [review] Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 to test... - apply patch - build package - confirm in about.pl that minimum versions are updated Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 21.11, thanks to everybody involved! (In reply to Jonathan Druart from comment #2) > root@kohadevbox:koha(master)$ apt-cache policy libjson-validator-perl > libjson-validator-perl: > Installed: 3.25+dfsg-1+koha3 > Candidate: 3.25+dfsg-1+koha3 > Version table: > *** 3.25+dfsg-1+koha3 500 > 500 http://debian.koha-community.org/koha-staging dev/main amd64 > Packages > 100 /var/lib/dpkg/status > 0.92+dfsg-1 500 > 500 http://httpredir.debian.org/debian stretch/main amd64 Packages > > > Why is JSON::Validator 3.14? the package name has now been updated/corrected to handle deb12 $ apt-cache policy libjson-validator-perl libjson-validator-perl: Installed: 4.99.1+really3.14-koha3 Candidate: 4.99.1+really3.14-koha3 Version table: *** 4.99.1+really3.14-koha3 500 500 http://debian.koha-community.org/koha 20.11/main amd64 Packages 100 /var/lib/dpkg/status (In reply to Jonathan Druart from comment #5) > Pushed to master for 21.11, thanks to everybody involved! hi, can we get this can be backported thru to 19.11? (In reply to Mason James from comment #7) > (In reply to Jonathan Druart from comment #5) > > Pushed to master for 21.11, thanks to everybody involved! > > hi, can we get this can be backported thru to 19.11? CCing RMaints for that. What minimal testing is needed? Must we build packages locally and install? IIUC if something goes wrong so will the CI image. And the API tests will catch that so I guess we can backport without worry. Pushed to 21.05.x for 21.05.08 I will wait until this is pushed to 20.11.x to backport it to 19.11.x.. I have the following conflict with 20.11.x <<<<<<< HEAD requires 'YAML', '0.71'; requires 'YAML::Syck', '0.71'; ||||||| parent of 81ce0e2db5 (Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16) requires 'YAML::XS', '0.67'; ======= requires 'YAML::XS', '0.76'; >>>>>>> 81ce0e2db5 (Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16) This diff3 conflictstyle tells that 20.11.x has YAML and YAML::Syck which on the next Koha versions were replaced by YAML::XS. Should I just add YAML::XS 0.76 ? (In reply to Victor Grousset/tuxayo from comment #13) > I have the following conflict with 20.11.x > > <<<<<<< HEAD > requires 'YAML', '0.71'; > requires 'YAML::Syck', '0.71'; > ||||||| parent of 81ce0e2db5 (Bug 28926: Update cpanfile for > Mojolicious::Plugin::OpenAPI v2.16) > requires 'YAML::XS', '0.67'; > ======= > requires 'YAML::XS', '0.76'; > >>>>>>> 81ce0e2db5 (Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16) > > > This diff3 conflictstyle tells that 20.11.x has YAML and YAML::Syck which on > the next Koha versions were replaced by YAML::XS. > > Should I just add YAML::XS 0.76 ? lets attempt to add this patch without any YAML::* updates first if problems occue with CI testing, we can add 27673 and 22824, or revert > lets attempt to add this patch without any YAML::* updates first
Thanks, it works! :)
Backported: Pushed to 20.11.x branch for 20.11.15
Backported to 19.11.x for 19.11.26 Build is failing on 19.11.x, so patch doesn't apply. Please supply a 19.11 patch if you require me to backport it to 19.11.x |