| Summary: | Sort1 and Sort2 should be included in BorrowerUnwantedField and related sysprefs | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | System Administration | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | dcook, emmi.takkinen, fridolin.somers, gmcharlt, hagud, joonas.kylmala, kyle, lucas, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.04,20.11.10
|
|
| Circulation function: | |||
| Bug Depends on: | 22844 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 28936: Add sort1/sort2 to borrowers.json
Bug 28936: Add sort1/sort2 to borrowers.json Bug 28936: Add sort1/sort2 to borrowers.json |
||
|
Description
Andrew Fuerste-Henry
2021-09-01 12:51:15 UTC
Created attachment 124413 [details] [review] Bug 28936: Add sort1/sort2 to borrowers.json To Test: 1. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences, sort1 and sort2 cannot be hidden or required 2. Apply patch 3. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences again, you should see sort1 and sort2 4. Since sort1 and sort2 are now added to borrowers.json we must also check the system preferences PatronQuickAddFields & PatronDuplicateMatchingAddFields 5. They should both now include sort1 and sort2, check to make sure they work with these two system preferences 6. Look at the system preferences PatronSelfRegistrationBorrowerMandatoryField, PatronSelfRegistrationBorrowerUnwantedField, and PatronSelfModificationBorrowerUnwantedField 7. sort1 and sort2 should be disabled in these OPAC system preferences This patch does not attempt to add sort1 or sort2 to the self reg or borrower mod pages. If they should be added, which I am not sure they should, we should do so in a seperate bug Created attachment 124516 [details] [review] Bug 28936: Add sort1/sort2 to borrowers.json To Test: 1. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences, sort1 and sort2 cannot be hidden or required 2. Apply patch 3. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences again, you should see sort1 and sort2 4. Since sort1 and sort2 are now added to borrowers.json we must also check the system preferences PatronQuickAddFields & PatronDuplicateMatchingAddFields 5. They should both now include sort1 and sort2, check to make sure they work with these two system preferences 6. Look at the system preferences PatronSelfRegistrationBorrowerMandatoryField, PatronSelfRegistrationBorrowerUnwantedField, and PatronSelfModificationBorrowerUnwantedField 7. sort1 and sort2 should be disabled in these OPAC system preferences This patch does not attempt to add sort1 or sort2 to the self reg or borrower mod pages. If they should be added, which I am not sure they should, we should do so in a seperate bug Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Created attachment 124522 [details] [review] Bug 28936: Add sort1/sort2 to borrowers.json To Test: 1. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences, sort1 and sort2 cannot be hidden or required 2. Apply patch 3. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences again, you should see sort1 and sort2 4. Since sort1 and sort2 are now added to borrowers.json we must also check the system preferences PatronQuickAddFields & PatronDuplicateMatchingAddFields 5. They should both now include sort1 and sort2, check to make sure they work with these two system preferences 6. Look at the system preferences PatronSelfRegistrationBorrowerMandatoryField, PatronSelfRegistrationBorrowerUnwantedField, and PatronSelfModificationBorrowerUnwantedField 7. sort1 and sort2 should be disabled in these OPAC system preferences This patch does not attempt to add sort1 or sort2 to the self reg or borrower mod pages. If they should be added, which I am not sure they should, we should do so in a seperate bug Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Passing QA. Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.04 Pushed to 20.11.x for 20.11.10 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |