| Summary: | Routing list holds are broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Chris Cormack <chris> |
| Component: | Serials | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | BLOCKED --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | amitddng135, andrewfh, cookie.wolfrom, david, jonathan.druart, koha, marjorie.barry-vila, maude.boudreau, michaela.sieber, patrick.robitaille, pierre.genty |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19862 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 31330 | ||
| Bug Blocks: | |||
| Attachments: |
subscription holds
Bug 2894: Fix Routing list holds Bug 2894: Fix Routing list holds |
||
|
Description
Chris Cormack
2010-05-21 00:57:40 UTC
I never use(d) routing lists. Could anyone confirm this problem ? Otherwise, i'll close the bug Created attachment 7758 [details] subscription holds Ok, I have retested this on current master and something is seriously going wrong here. Updating version and severity as this feature seems to be totally broken right now. Test 1: - Create a new subscription, choose to NOT add items for the subscription - Create a routing list - Receive an issue - Check for holds on the record > Holds are created although you have no items for this record I think there should be a check somewhere preventing that. Perhaps making it not possible to create routing lists when no items are created? I am not sure how this was supposed to work. Test 2: - Create a new subscription, choose to create items for the subscription on receive - Create a routing list - Receive an issue - Check for holds on the record > Holds are created, but those are indeed not item level. It seems to be some new kind of hold actually - 'only this type'? (see screenshot) From the template: [% ELSE %] [% IF ( reserveloo.constrainttypeo ) %] only this type :<b>[% reserveloo.volumeddesc %] [% reserveloo.itemtype %]</b> [% END %] [% END %] [% END %] (In reply to comment #2) > Created attachment 7758 [details] > subscription holds > > Ok, I have retested this on current master and something is seriously going > wrong here. Updating version and severity as this feature seems to be > totally broken right now. > > Test 1: > - Create a new subscription, choose to NOT add items for the subscription > - Create a routing list > - Receive an issue > - Check for holds on the record > > Holds are created although you have no items for this record > > I think there should be a check somewhere preventing that. > Perhaps making it not possible to create routing lists when no items are > created? > I am not sure how this was supposed to work. > > Test 2: > - Create a new subscription, choose to create items for the subscription on > receive > - Create a routing list > - Receive an issue > - Check for holds on the record > > Holds are created, but those are indeed not item level. It seems to be some new kind of hold actually - 'only this type'? (see screenshot) Some kind of old hold that people have since broken. Ill have a look > > From the template: > [% ELSE %] > [% IF ( reserveloo.constrainttypeo ) %] > only this type :<b>[% reserveloo.volumeddesc %] [% > reserveloo.itemtype %]</b> > [% END %] > [% END %] > [% END %] There is another side effect of this: If you have RoutingListAddReserves to "place" in a 3.18 and you receive a new issue for the subscription, Koha tries to add a hold to the people on the routing list. This hold will break the new Ajax holds display so that no holds at all will display for this patron. Solution: Turn off the pref and delete the holds with the wrong constraint type. I thinks as this pref is causing problems when turned on, we should make sure it's turned off by default for new installations. Maybe also add a warning? Fixing the problem would of course be preferred... but I think as this has been broken for a longer time, it's probably not easy. Hm, maybe! At least the case when an item is created! Hi, are someone is working on this bug? It could be nice to use the systeme preference RoutingListAddReserves so when the users that you add to the circulation list will have automatically a created bookings in the order of adding to the list. Thanks, Patrick. Sadly, still valid after almost 9+ years :( I can confirm that on master currently holds for routing lists are still bib-level. They should be item-level. When the feature is turned on it not only doesn't work now, but it also makes receiving issues explode - trying to place a hold insuccessfully in the background. Created attachment 138971 [details] [review] Bug 2894: Fix Routing list holds This is a try to fix a very old bug. Not familiar with the workflow so cannot confirm it will fix everything. The idea is to fix the behaviour of RoutingListAddReserves, and create item-level holds (so only if items have been created). Patch for discussion. Now that there are patches here and on the other linked bugs, can I get feedback on them please? Changing status to Needs Signoff in hope to get feedback. I think the idea to fix the behaviour of RoutingListAddReserves, and create item-level holds (so only if items have been created) is correct. When trying to apply patch I got the error message: "Cannot apply cleanly patches from bug 31335. Everything will be left dirty." Perhaps someone / developer could first have a look on bug 31335. As far as I understand this is about code cleaning. And there should be a new test plan. Perhaps like this: - Set systempref RoutingListAddReserves to "Place received serials on hold if they are on a routing list." - Create a new subscription, e.g. for title "Chapman" (ISSN 0308-2695) - choose to create items for the subscription on receive - Create a routing list with at least two recipients - Receive an issue and fill item form (item type) - Click on 'Print List' in column Routing - Check for holds on the biblio record > Holds are created, but those are indeed not item level. (see Holds column Details = Next available) - Apply Patch - Receive next issue with item - Click on 'Print List' in column Routing - Check for holds - Holds should be on the item level for new received serial items Created attachment 164892 [details] [review] Bug 2894: Fix Routing list holds This is a try to fix a very old bug. Not familiar with the workflow so cannot confirm it will fix everything. The idea is to fix the behaviour of RoutingListAddReserves, and create item-level holds (so only if items have been created). Sorry I totally forgot about this one. I had a very quick short at rebasing it but haven't tested it! After the patch is applied, I got this error trace when: 1. Initially creating the routing list (I didn't get this if I set up the routing list before the patch was applied) (step 3 of the test plan) 2. When printing the routing list (after the patch is applied) (step 9 of the test plan): Could not compile /kohadevbox/koha/serials/routing-preview.pl: Global symbol "$serialitem" requires explicit package name (did you forget to declare "my $serialitem"?) at /kohadevbox/koha/serials/routing-preview.pl line 72. Global symbol "$serialitem" requires explicit package name (did you forget to declare "my $serialitem"?) at /kohadevbox/koha/serials/routing-preview.pl line 85. Global symbol "$serialitem" requires explicit package name (did you forget to declare "my $serialitem"?) at /kohadevbox/koha/serials/routing-preview.pl line 95. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/serials/routing-preview.pl line 153. at /usr/share/perl5/CGI/Compile.pm line 144 in CGI::Compile::compile at /usr/share/perl5/CGI/Compile.pm line 144 ..... Test plan (using KTD, mostly the same as comment #16): 1. Set system preference RoutingListAddReserves to "Place" ("Place received serials on hold if they are on a routing list."). 2. Create a new subscription for Chapman (ISSN 0308-2695; biblionumber = 4) and choose to create an item record when receiving this serial. I set it up using these details: . Serials > + New subscription . Vendor: 1 (Search for vendor > Search > Choose) . Record: 44 . When receiving this serial: Create an item record . Library: Centerville . Location: New materials shelf . Collection: Non-fiction . Item type: Continuing resources . Grace period: 2 . Number of issues to display to staff: 25 . Number of issues to display to the public: 25 Next . First publication date: 01/01/2024 . Frequency: 1/week . Subscription length: issues 52 . Subscription end date: 01/01/2024 . Numbering pattern: Number . Number > Begins with: 500 . Click 'Test prediction pattern' Save subscription 3. Create a routing list with at least two recipients: . From the menu to the left, select 'Create routing list' . Click '+ Add recipients' . Search for and add at least two patrons (I added Henry and Mary) . Close . Save 4. Receive an issue and add the item information: . Serials > Search . Select 'Chapman' . Click the 'Receive' action from the menu . In the status column, change 'Expected' to 'Arrived' . Add a barcode to the item form . Save 5. Click on 'Print list' in column Routing (for issues with the arrived status). 6. On the record page, check the holds section: ==> Result: Holds are created, but those are record level holds, not item level holds (Holds column, Details = Next available). 7. Apply the patch. 8. Receive the next issue with item (repeat of step 4). 9. Click on 'Print list' in column Routing (for issues with the arrived status) (repeat of step 5). 10. On the record page, check the holds section: ==> Result: Holds are created, and these are now item level holds. Sorry for the confusion, this patch has initially been written on top of bug 31330. |