| Summary: | 500 error when choosing patron for purchase suggestion | ||
|---|---|---|---|
| Product: | Koha | Reporter: | jstallings |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05
|
|
| Circulation function: | |||
| Bug Depends on: | 23271, 23590 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl
Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl |
||
|
Description
jstallings
2021-09-03 03:18:44 UTC
What error you have in the Koha log files? I get this error in master: The method Koha::Patron::Categories->search_limited is not covered by tests! As above, "The method Koha::Patron::Categories->search_limited is not covered by tests!" Full plack-error.log: https://pastebin.com/1hZnCGnD Nothing in intranet or other logs. Created attachment 124725 [details] [review] Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl commit f6e0b04f48e8f0a02dbb8d48152646257d9accba Bug 23271: Replace search_limited with search_with_library_limits We were modifying the occurrences of: Koha::Patron::Categories->search_limited; with: Koha::Patron::Categories->search_with_library_limits; But between the patch submission and the push, another occurrence has been added by bug 23590. Test plan: Create a new suggestion from staff and click "select manager" Without the patch, notice the error: The method Koha::Patron::Categories->search_limited is not covered by tests! With the patch applied everything is working correctly Created attachment 124751 [details] [review] Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl commit f6e0b04f48e8f0a02dbb8d48152646257d9accba Bug 23271: Replace search_limited with search_with_library_limits We were modifying the occurrences of: Koha::Patron::Categories->search_limited; with: Koha::Patron::Categories->search_with_library_limits; But between the patch submission and the push, another occurrence has been added by bug 23590. Test plan: Create a new suggestion from staff and click "select manager" Without the patch, notice the error: The method Koha::Patron::Categories->search_limited is not covered by tests! With the patch applied everything is working correctly Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 |