Summary: | Improve Koha::Patron::can_see_patron_infos efficiency | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Patrons | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, martin.renvoize, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05,20.11.12
|
|
Circulation function: | |||
Bug Depends on: | 18403 | ||
Bug Blocks: | |||
Attachments: |
Bug 28973: Improve Koha::Patron::can_see_patron_infos efficiency
Bug 28973: Improve Koha::Patron::can_see_patron_infos efficiency Bug 28973: Improve Koha::Patron::can_see_patron_infos efficiency |
Description
Kyle M Hall (khall)
2021-09-08 12:31:34 UTC
Created attachment 124654 [details] [review] Bug 28973: Improve Koha::Patron::can_see_patron_infos efficiency The method can_see_patron_infos looks up a row in the branches table by branchcode just to get the branchcode it already has. This seems inefficient. Test Plan: 1) Apply this patch 2) No changes should be noted Created attachment 124656 [details] [review] Bug 28973: Improve Koha::Patron::can_see_patron_infos efficiency The method can_see_patron_infos looks up a row in the branches table by branchcode just to get the branchcode it already has. This seems inefficient. Test Plan: 1) Apply this patch 2) No changes should be noted Created attachment 127218 [details] [review] Bug 28973: Improve Koha::Patron::can_see_patron_infos efficiency The method can_see_patron_infos looks up a row in the branches table by branchcode just to get the branchcode it already has. This seems inefficient. Test Plan: 1) Apply this patch 2) No changes should be noted Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This is a no brainer.. straight to PQA Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.12 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |