| Summary: | Negative rental amounts can be saved but not enforced | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, joonas.kylmala, kyle, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05,21.11.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 28985: Force positive numbers for itemtype charge fields
Bug 28985: Force positive numbers for itemtype charge fields Bug 28985: Force positive numbers for itemtype charge fields |
||
|
Description
Andrew Fuerste-Henry
2021-09-09 14:56:48 UTC
Created attachment 124758 [details] [review] Bug 28985: Force positive numbers for itemtype charge fields This patch adds a min attribute to the fields on this page and adds other cost related fields to validator To test: 1 - Apply patch 2 - Browse to Administration->Item types 3 - Edit or create an item type 4 - Attempt to place a negative or non numeric value in: Daily rental charge Hourly rental charge Default replacement cost Processing fee 5 - You should not be able to Created attachment 124761 [details] [review] Bug 28985: Force positive numbers for itemtype charge fields This patch adds a min attribute to the fields on this page and adds other cost related fields to validator To test: 1 - Apply patch 2 - Browse to Administration->Item types 3 - Edit or create an item type 4 - Attempt to place a negative or non numeric value in: Daily rental charge Hourly rental charge Default replacement cost Processing fee 5 - You should not be able to Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 124798 [details] [review] Bug 28985: Force positive numbers for itemtype charge fields This patch adds a min attribute to the fields on this page and adds other cost related fields to validator To test: 1 - Apply patch 2 - Browse to Administration->Item types 3 - Edit or create an item type 4 - Attempt to place a negative or non numeric value in: Daily rental charge Hourly rental charge Default replacement cost Processing fee 5 - You should not be able to Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Pushed to master for 21.11, thanks to everybody involved! I see it is in 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.11 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |