Summary: | Resolve warning from undefined BIG_LOOP | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, joonas.kylmala, kyle, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00,21.05.05,20.11.11
|
Circulation function: | |
Attachments: |
Bug 28992: Resolve warning on BIG_LOOP
Bug 28992: Resolve warning on BIG_LOOP |
Description
Marcel de Rooy
2021-09-10 08:27:38 UTC
Created attachment 124726 [details] [review] Bug 28992: Resolve warning on BIG_LOOP Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/ addbiblio.tt line 896. Came across it when testing 28608. Could have been a QA follow-up. Test plan: If you run QA tools on this patch, you should see the warning only when processing files before patches. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Super trivial one liner. Self signoff. Created attachment 124812 [details] [review] Bug 28992: Resolve warning on BIG_LOOP Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/ addbiblio.tt line 896. Came across it when testing 28608. Could have been a QA follow-up. Test plan: If you run QA tools on this patch, you should see the warning only when processing files before patches. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.11 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |