Summary: | Switch magnifying glass in staff detail pages to FA icon | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
Bug Depends on: | |||
Bug Blocks: | 20362 | ||
Attachments: |
Bug 28993: Switch magnifying class in staff detail pages to FA icon
Bug 28993: Switch magnifying class in staff detail pages to FA icon Bug 28993: Switch magnifying class in staff detail pages to FA icon |
Description
Katrin Fischer
2021-09-10 09:14:23 UTC
I'd like to also replace the image on the authority detail page but I'm confused by this section of the template (authorities/detail.tt): [% IF ( subfiel.link ) %] <a class="authlink" href="/cgi-bin/koha/catalogue/search.pl?op=do_search&marclist=[% subfiel.link | uri %]&operator==&type=intranet&value=[% subfiel.marc_value |url %]"> <i class="fa fa-search" aria-label="Search on [% subfiel.marc_value | html %]" title="Search on [% subfiel.marc_value | html %]"></i> </a> [% END %] [% IF ( subfiel.authority ) %] <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% subfiel.authority | uri %]" class="button">Auth</a> [% END %] Are subfiel.link and subfiel.authority really relevant to an authority record? I'm wondering if it's actually copy and paste from the MARC view. Authorities can also be linked to each other hierarchically - could that have to do with it? Created attachment 129355 [details] [review] Bug 28993: Switch magnifying class in staff detail pages to FA icon This patch modifies the staff interface's bibliographic detail XSL so that a Font Awesome is used instead of a magnifying glass image when listing authority subject headings. The patch also corrects two other places where the image is used so that the image can be removed. Some markup from authorities.detail.tt is removed because it appears to be unused (a copy and paste from catalogue/detail.tt). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - To view the changes to the staff interface bibliographic detail page, locate a record which has at least one subject heading which is linked to a subject authority record. - The subject heading link should be followed by a magifying glass (Font Awesome) icon which links to the authority record's detail page. - View a similar change to the MARC detail page for the record. Confirm that the subject headings are followed by a link to the authority detail page. - Follow the authority search link to locate and view an authority record. The information on the authority detail page should be correct. Created attachment 129715 [details] [review] Bug 28993: Switch magnifying class in staff detail pages to FA icon This patch modifies the staff interface's bibliographic detail XSL so that a Font Awesome is used instead of a magnifying glass image when listing authority subject headings. The patch also corrects two other places where the image is used so that the image can be removed. Some markup from authorities.detail.tt is removed because it appears to be unused (a copy and paste from catalogue/detail.tt). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - To view the changes to the staff interface bibliographic detail page, locate a record which has at least one subject heading which is linked to a subject authority record. - The subject heading link should be followed by a magifying glass (Font Awesome) icon which links to the authority record's detail page. - View a similar change to the MARC detail page for the record. Confirm that the subject headings are followed by a link to the authority detail page. - Follow the authority search link to locate and view an authority record. The information on the authority detail page should be correct. Signed-off-by: David Nind <david@davidnind.com> Created attachment 129981 [details] [review] Bug 28993: Switch magnifying class in staff detail pages to FA icon This patch modifies the staff interface's bibliographic detail XSL so that a Font Awesome is used instead of a magnifying glass image when listing authority subject headings. The patch also corrects two other places where the image is used so that the image can be removed. Some markup from authorities.detail.tt is removed because it appears to be unused (a copy and paste from catalogue/detail.tt). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - To view the changes to the staff interface bibliographic detail page, locate a record which has at least one subject heading which is linked to a subject authority record. - The subject heading link should be followed by a magifying glass (Font Awesome) icon which links to the authority record's detail page. - View a similar change to the MARC detail page for the record. Confirm that the subject headings are followed by a link to the authority detail page. - Follow the authority search link to locate and view an authority record. The information on the authority detail page should be correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Especially like the newly added aria-label :) magnifying "glass" 🔍 I'll fix commit message when pushing to master Pushed to master for 22.05, thanks to everybody involved 🦄 |