| Summary: | Automatic renewal due to RenewAccruingItemWhenPaid should not be considered Seen | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrewfh> |
| Component: | Circulation | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arthur.suzuki, gmcharlt, kyle.m.hall, kyle, lucas, martin.renvoize, matt.blenkinsop |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
| Circulation function: | |||
| Bug Depends on: | 24083, 30275 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 29021: RenewAccruingItemWhenPaid renewals are not seen
Bug 29021: RenewAccruingItemWhenPaid renewals are not seen Bug 29021: RenewAccruingItemWhenPaid renewals are not seen Bug 29021: (QA follow-up) Fix for new parameter, add unit test Bug 29021: (QA follow-up) Remove useless warnings |
||
|
Description
Andrew Fuerste-Henry
2021-09-14 17:59:46 UTC
Created attachment 134897 [details] [review] Bug 29021: RenewAccruingItemWhenPaid renewals are not seen This patch updates the call to AddRewewal from Koha::Accounts to makr the renewal as unseen. Created attachment 144503 [details] [review] Bug 29021: RenewAccruingItemWhenPaid renewals are not seen This patch updates the call to AddRewewal from Koha::Accounts to makr the renewal as unseen. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 145761 [details] [review] Bug 29021: RenewAccruingItemWhenPaid renewals are not seen This patch updates the call to AddRewewal from Koha::Accounts to makr the renewal as unseen. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 145762 [details] [review] Bug 29021: (QA follow-up) Fix for new parameter, add unit test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 145799 [details] [review] Bug 29021: (QA follow-up) Remove useless warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Backported to 22.05.x for upcoming 22.05.10 I should not have backported this, tests are failing because there is no 'Koha::Checkouts::Renewals' in 22.05. That looks like it was added by Bug 30275. I will revert this patchset from 22.05.x. Patchset reverted from 22.05.x Same as Lukas, can't backport |