Summary: | Accessibility: OPAC masthead_search label doesn't have sufficient contrast ratio | ||
---|---|---|---|
Product: | Koha | Reporter: | Henry Bolshaw <bolshawh> |
Component: | OPAC | Assignee: | Henry Bolshaw <bolshawh> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00,21.05.05
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 28188 | ||
Attachments: |
Bug 29035: Accessibility: OPAC masthead_search label doesn't have sufficient contrast ratio
Bug 29035: Accessibility: OPAC masthead_search label doesn't have sufficient contrast ratio Bug 29035: Accessibility: OPAC masthead_search label doesn't have sufficient contrast ratio |
Description
Henry Bolshaw
2021-09-16 03:20:26 UTC
Created attachment 124923 [details] [review] Bug 29035: Accessibility: OPAC masthead_search label doesn't have sufficient contrast ratio This patch changes the colour of the masthead search label to improve accessibility and make it easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to test the contrast ratio. 2. Confirm that the search label has insufficient contrast. 3. Apply the patch and rebuild the OPAC CSS: yarn build --view opac 4. Use the accessibility tool to confirm the contrast ratio now meets accessibility requirements. 5. Check that the OPAC still looks ok after the changes. I agree with this change. But I also propose an enhancement Bug 29066 to remove this text. Created attachment 125141 [details] [review] Bug 29035: Accessibility: OPAC masthead_search label doesn't have sufficient contrast ratio This patch changes the colour of the masthead search label to improve accessibility and make it easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to test the contrast ratio. 2. Confirm that the search label has insufficient contrast. 3. Apply the patch and rebuild the OPAC CSS: yarn build --view opac 4. Use the accessibility tool to confirm the contrast ratio now meets accessibility requirements. 5. Check that the OPAC still looks ok after the changes. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125324 [details] [review] Bug 29035: Accessibility: OPAC masthead_search label doesn't have sufficient contrast ratio This patch changes the colour of the masthead search label to improve accessibility and make it easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to test the contrast ratio. 2. Confirm that the search label has insufficient contrast. 3. Apply the patch and rebuild the OPAC CSS: yarn build --view opac 4. Use the accessibility tool to confirm the contrast ratio now meets accessibility requirements. 5. Check that the OPAC still looks ok after the changes. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 |