Summary: | Improve formatting of entry form in Additional Contents | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
Circulation function: | |||
Bug Depends on: | 24387 | ||
Bug Blocks: | |||
Attachments: |
Bug 29042: Improve formatting of entry form in Additional Contents
Bug 29042: Improve formatting of entry form in Additional Contents Bug 29042: Improve formatting of entry form in Additional Contents |
Description
Owen Leonard
2021-09-16 15:26:33 UTC
Created attachment 124939 [details] [review] Bug 29042: Improve formatting of entry form in Additional Contents This patch makes some corrections to the Additional Contents template so that the content entry form can be styled like other similar forms in the staff interface. The patch also updates the form's "title" field so that it is longer and has a maxlength attribute matching the size of the table column. To test, apply the patch and go to Tools -> News. - Create a new news item. - In the entry form, confirm that the "Title" and "Content" fields are styled consistently with other similar forms. - Confirm that the "title" field is longer. Created attachment 125403 [details] [review] Bug 29042: Improve formatting of entry form in Additional Contents This patch makes some corrections to the Additional Contents template so that the content entry form can be styled like other similar forms in the staff interface. The patch also updates the form's "title" field so that it is longer and has a maxlength attribute matching the size of the table column. To test, apply the patch and go to Tools -> News. - Create a new news item. - In the entry form, confirm that the "Title" and "Content" fields are styled consistently with other similar forms. - Confirm that the "title" field is longer. Signed-off-by: David Nind <david@davidnind.com> Almost sad to see this line removed :) <fieldset>[%# FIXME We should remove list-style:none; and use class="rows" here but it does not work. Owen please help! %]> Created attachment 125655 [details] [review] Bug 29042: Improve formatting of entry form in Additional Contents This patch makes some corrections to the Additional Contents template so that the content entry form can be styled like other similar forms in the staff interface. The patch also updates the form's "title" field so that it is longer and has a maxlength attribute matching the size of the table column. To test, apply the patch and go to Tools -> News. - Create a new news item. - In the entry form, confirm that the "Title" and "Content" fields are styled consistently with other similar forms. - Confirm that the "title" field is longer. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! |