Bug 29050

Summary: Add punctuation in Unseen Renewals message
Product: Koha Reporter: Andrew Fuerste-Henry <andrewfh>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: arthur.suzuki, gmcharlt, jonathan.druart, kyle.m.hall, lucas, victor
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.04, 21.11.11
Bug Depends on: 24083    
Bug Blocks:    
Attachments: Bug 29050: Added a punctuation between renewal messages
Bug 29050: Added a punctuation between renewal messages
Bug 29050: Added a punctuation between renewal messages
Bug 29050: (follow-up) Replace & with and

Description Andrew Fuerste-Henry 2021-09-17 17:09:43 UTC
In the Checkouts tab of the patron record, the counts of renewals and unseen renewals need some punctuation. Right now they say something like "(W of X renewals remainingY of Z unseen renewals remaining." That needs at least a comma and a space in the middle, for ""(W of X renewals remaining, Y of Z unseen renewals remaining."
Comment 1 Koha Training Catalyst 2022-07-07 23:33:25 UTC
Created attachment 137348 [details] [review]
Bug 29050: Added a punctuation between renewal messages

Test plan:

1. First step is to go to administration > then system preferences
2. Set unseenrenewal to "allow"
3. Go to administatrion > circulation and fines rule
4. Set unseenrenewals count to any number
5. Check out an item to a patron and go to the checkouts tab
6. Renew the item
7. Notice that the renewal messages have no seperation
8. Apply the patch
9. Notice there is now a "&" in the spacing between renewal messages

Sponsored-by: Catalyst IT
Comment 2 Chris Cormack 2022-07-07 23:41:27 UTC
Created attachment 137350 [details] [review]
Bug 29050: Added a punctuation between renewal messages

Test plan:

1. First step is to go to administration > then system preferences
2. Set unseenrenewal to "allow"
3. Go to administatrion > circulation and fines rule
4. Set unseenrenewals count to any number
5. Check out an item to a patron and go to the checkouts tab
6. Renew the item
7. Notice that the renewal messages have no seperation
8. Apply the patch
9. Notice there is now a "&" in the spacing between renewal messages

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Does what it says it does, still needs independent sign off
Comment 3 Katrin Fischer 2022-07-08 09:22:29 UTC
Created attachment 137385 [details] [review]
Bug 29050: Added a punctuation between renewal messages

Test plan:

1. First step is to go to administration > then system preferences
2. Set unseenrenewal to "allow"
3. Go to administatrion > circulation and fines rule
4. Set unseenrenewals count to any number
5. Check out an item to a patron and go to the checkouts tab
6. Renew the item
7. Notice that the renewal messages have no seperation
8. Apply the patch
9. Notice there is now a "&" in the spacing between renewal messages

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Katrin Fischer 2022-07-08 09:23:10 UTC
Thank you for your patch, Nisha! Going straight to PQA for this one.
Comment 5 David Nind 2022-07-08 11:13:49 UTC
Created attachment 137403 [details] [review]
Bug 29050: (follow-up) Replace & with and

See the terminology list https://wiki.koha-community.org/wiki/Terminology

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Tomás Cohen Arazi 2022-07-08 18:15:18 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass 2022-08-12 16:02:17 UTC
Backported to 22.05.x for 22.05.04
Comment 8 Arthur Suzuki 2022-08-16 12:10:14 UTC
pushed to 21.11.x for 21.11.11
Comment 9 Victor Grousset/tuxayo 2022-08-19 22:45:47 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.