| Summary: | Add punctuation in Unseen Renewals message | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | arthur.suzuki, gmcharlt, jonathan.druart, kyle.m.hall, lucas, victor |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.04, 21.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | 24083 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 29050: Added a punctuation between renewal messages
Bug 29050: Added a punctuation between renewal messages Bug 29050: Added a punctuation between renewal messages Bug 29050: (follow-up) Replace & with and |
||
|
Description
Andrew Fuerste-Henry
2021-09-17 17:09:43 UTC
Created attachment 137348 [details] [review] Bug 29050: Added a punctuation between renewal messages Test plan: 1. First step is to go to administration > then system preferences 2. Set unseenrenewal to "allow" 3. Go to administatrion > circulation and fines rule 4. Set unseenrenewals count to any number 5. Check out an item to a patron and go to the checkouts tab 6. Renew the item 7. Notice that the renewal messages have no seperation 8. Apply the patch 9. Notice there is now a "&" in the spacing between renewal messages Sponsored-by: Catalyst IT Created attachment 137350 [details] [review] Bug 29050: Added a punctuation between renewal messages Test plan: 1. First step is to go to administration > then system preferences 2. Set unseenrenewal to "allow" 3. Go to administatrion > circulation and fines rule 4. Set unseenrenewals count to any number 5. Check out an item to a patron and go to the checkouts tab 6. Renew the item 7. Notice that the renewal messages have no seperation 8. Apply the patch 9. Notice there is now a "&" in the spacing between renewal messages Sponsored-by: Catalyst IT Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Does what it says it does, still needs independent sign off Created attachment 137385 [details] [review] Bug 29050: Added a punctuation between renewal messages Test plan: 1. First step is to go to administration > then system preferences 2. Set unseenrenewal to "allow" 3. Go to administatrion > circulation and fines rule 4. Set unseenrenewals count to any number 5. Check out an item to a patron and go to the checkouts tab 6. Renew the item 7. Notice that the renewal messages have no seperation 8. Apply the patch 9. Notice there is now a "&" in the spacing between renewal messages Sponsored-by: Catalyst IT Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Thank you for your patch, Nisha! Going straight to PQA for this one. Created attachment 137403 [details] [review] Bug 29050: (follow-up) Replace & with and See the terminology list https://wiki.koha-community.org/wiki/Terminology Signed-off-by: David Nind <david@davidnind.com> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.04 pushed to 21.11.x for 21.11.11 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. |