| Summary: | Seen renewal methods incorrectly blocked | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Circulation | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | arthur.suzuki, caroline.cyr-la-rose, gmcharlt, kyle.m.hall, kyle, lucas, martin.renvoize, nick, tomascohen, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.05, 21.11.12, 21.05.19
|
|
| Circulation function: | |||
| Bug Depends on: | 24083 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 29051: Enable seen renewal in the staff client
Bug 29051: Update svc api to allow seen renewals Bug 29051: Enable seen renewal in the staff client Bug 29051: Update svc api to allow seen renewals Bug 29051: Enable seen renewal in the staff client Bug 29051: Update svc api to allow seen renewals |
||
|
Description
Andrew Fuerste-Henry
2021-09-17 17:28:42 UTC
Hmm, this looks like a regression.. I agree it should allow for renewal in the staff client as seen. Created attachment 134898 [details] [review] Bug 29051: Enable seen renewal in the staff client This patch updates the javascript for the checkouts table to add the checkbox back in for the case where too_unseen is the error returned by CanBookBeRenewed, allowing such issues to be renewed. Created attachment 134899 [details] [review] Bug 29051: Update svc api to allow seen renewals This patch updates the svc/renew api endpoint to allow seen renewals when appropriate OK, those two patches should resolve: 7- try to renew with the Renew Selected button in the Checkouts tab, you cannot select this checkout 8- try to renew with the Renew All button in the Checkouts tab, the item does not renew Still working on the other avenues. I'm not sure about the other two.. we don't have a clear way of saying "This wasn't a seen renewal" for them (On the table version we default to 'seen' but you have the checkbox to set 'unseen' and we handle it nicely as a result).. For the search header renew, perhaps we're OK to always assume it's 'seen' (as in theory you are always scanning into that box), but for the normal Checkout way it could be via a search.. so maybe we should not always assume 'seen' or at least give the option to do an 'unseen' at this point.. think about telephone renewals as a workflow.. What do you think Andrew? (In reply to Martin Renvoize from comment #5) > I'm not sure about the other two.. we don't have a clear way of saying "This > wasn't a seen renewal" for them (On the table version we default to 'seen' > but you have the checkbox to set 'unseen' and we handle it nicely as a > result).. > > For the search header renew, perhaps we're OK to always assume it's 'seen' > (as in theory you are always scanning into that box), but for the normal > Checkout way it could be via a search.. so maybe we should not always assume > 'seen' or at least give the option to do an 'unseen' at this point.. think > about telephone renewals as a workflow.. > > What do you think Andrew? Not Andrew, but I assume this is OK. This at least leaves staff with a way to do a seen renewal. I reckon go with this for now and work on the other bits as a distinct bug.. I've run out of time to continue here. Created attachment 136780 [details] [review] Bug 29051: Enable seen renewal in the staff client This patch updates the javascript for the checkouts table to add the checkbox back in for the case where too_unseen is the error returned by CanBookBeRenewed, allowing such issues to be renewed. Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com> Created attachment 136782 [details] [review] Bug 29051: Update svc api to allow seen renewals This patch updates the svc/renew api endpoint to allow seen renewals when appropriate Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com> 7 and 8 work with the patch! Thanks Andrew and Martin, this is major Created attachment 137271 [details] [review] Bug 29051: Enable seen renewal in the staff client This patch updates the javascript for the checkouts table to add the checkbox back in for the case where too_unseen is the error returned by CanBookBeRenewed, allowing such issues to be renewed. Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 137272 [details] [review] Bug 29051: Update svc api to allow seen renewals This patch updates the svc/renew api endpoint to allow seen renewals when appropriate Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.05 pushed to 21.11.x for 21.11.12 Backported: Pushed to 21.05.x branch for 21.05.19 Nothing to document I think. |