| Summary: | Make consistent use of spans and div with hint class | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 29052: Make consistent use of spans and div with hint class
Bug 29052: Make consistent use of spans and div with hint class Bug 29052: Make consistent use of spans and div with hint class Bug 29052 – Form field label display (before and after) Bug 29052: Make consistent use of spans and div with hint class |
||
|
Description
Owen Leonard
2021-09-17 18:04:30 UTC
Created attachment 125014 [details] [review] Bug 29052: Make consistent use of spans and div with hint class This patch makes minor HTML corrections to several templates, primarily to wrap form help text in <span class="hint"> or <div class="hint">. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the following pages to confirm that forms look correct: - Administration -> Authority types -> Authority type -> Edit. - Administration -> Authority types -> Authority type -> MARC structure. -> Subfields -> Edit. - Administration -> Authorised values -> View category -> New authorized value. - Administration -> Credit types -> New credit type. - Administration -> Debit types -> New debit type. - Administration -> Item types -> New item type. Also changed: Added link to ITEMTYPECAT authorized value page for users with the correct permission. - Administration -> MARC frameworks -> MARC structure -> Edit subfields. - Administration -> Patron attribute types -> New patron attribute type. - Administration -> Share content with Mana KB. - Administration -> Z39.50/SRU servers -> New Z39.50 server. Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29052: Make consistent use of spans and div with hint class Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss error: Failed to merge in the changes. Patch failed at 0001 Bug 29052: Make consistent use of spans and div with hint class Created attachment 126447 [details] [review] Bug 29052: Make consistent use of spans and div with hint class This patch makes minor HTML corrections to several templates, primarily to wrap form help text in <span class="hint"> or <div class="hint">. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the following pages to confirm that forms look correct: - Administration -> Authority types -> Authority type -> Edit. - Administration -> Authority types -> Authority type -> MARC structure. -> Subfields -> Edit. - Administration -> Authorised values -> View category -> New authorized value. - Administration -> Credit types -> New credit type. - Administration -> Debit types -> New debit type. - Administration -> Item types -> New item type. Also changed: Added link to ITEMTYPECAT authorized value page for users with the correct permission. - Administration -> MARC frameworks -> MARC structure -> Edit subfields. - Administration -> Patron attribute types -> New patron attribute type. - Administration -> Share content with Mana KB. - Administration -> Z39.50/SRU servers -> New Z39.50 server. Created attachment 126467 [details] [review] Bug 29052: Make consistent use of spans and div with hint class This patch makes minor HTML corrections to several templates, primarily to wrap form help text in <span class="hint"> or <div class="hint">. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the following pages to confirm that forms look correct: - Administration -> Authority types -> Authority type -> Edit. - Administration -> Authority types -> Authority type -> MARC structure. -> Subfields -> Edit. - Administration -> Authorised values -> View category -> New authorized value. - Administration -> Credit types -> New credit type. - Administration -> Debit types -> New debit type. - Administration -> Item types -> New item type. Also changed: Added link to ITEMTYPECAT authorized value page for users with the correct permission. - Administration -> MARC frameworks -> MARC structure -> Edit subfields. - Administration -> Patron attribute types -> New patron attribute type. - Administration -> Share content with Mana KB. - Administration -> Z39.50/SRU servers -> New Z39.50 server. Signed-off-by: David Nind <david@davidnind.com> Created attachment 126468 [details] Bug 29052 – Form field label display (before and after) One very small difference (and not a showstopper for me) is the display of the form field labels. They seem to wrap around more rather than display on one line - see the attached example. The Add item type (which I didn't take a screen shot of) is probably a better example. Overall, a really nice improvement! Created attachment 126549 [details] [review] Bug 29052: Make consistent use of spans and div with hint class This patch makes minor HTML corrections to several templates, primarily to wrap form help text in <span class="hint"> or <div class="hint">. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the following pages to confirm that forms look correct: - Administration -> Authority types -> Authority type -> Edit. - Administration -> Authority types -> Authority type -> MARC structure. -> Subfields -> Edit. - Administration -> Authorised values -> View category -> New authorized value. - Administration -> Credit types -> New credit type. - Administration -> Debit types -> New debit type. - Administration -> Item types -> New item type. Also changed: Added link to ITEMTYPECAT authorized value page for users with the correct permission. - Administration -> MARC frameworks -> MARC structure -> Edit subfields. - Administration -> Patron attribute types -> New patron attribute type. - Administration -> Share content with Mana KB. - Administration -> Z39.50/SRU servers -> New Z39.50 server. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I especially like the changes to the Z39.50 server page. :) Pushed to master for 21.11, thanks to everybody involved! |