Bug 29065

Summary:	Accessibility: OPAC clear search history link has insufficient contrast
Product:	Koha	Reporter:	Henry Bolshaw <bolshawh>
Component:	OPAC	Assignee:	Henry Bolshaw <bolshawh>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	bolshawh, kyle, martin.renvoize
Version:	Main	Keywords:	accessibility
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	21.11.00,21.05.05
Circulation function:
Bug Depends on:
Bug Blocks:	28188
Attachments:	Bug_29065: Accessibility OPAC clear search history link has insufficient contrast Bug 29065: Accessibility OPAC clear search history link has insufficient contrast Bug 29065: Accessibility OPAC clear search history link has insufficient contrast

Description Henry Bolshaw 2021-09-20 22:22:54 UTC

The contrast ratio for the OPAC Delete your search history link fails to meet accessibility guidelines.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user interface component, that are pure decoration, that are not visible to anyone, or that are part of a picture that contains significant other visual content, have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g. https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as well as specialist accessibility browser extensions like WAVE (https://wave.webaim.org/)

Comment 1 Henry Bolshaw 2021-09-20 22:33:52 UTC Comment hidden (obsolete)

Created attachment 125082 [details] [review]
Bug_29065: Accessibility OPAC clear search history link has insufficient contrast

This patch changes the colour of the clear search history link
on the OPAC to increase the contrast ratio, improve accessibility
and makes the text easier to read.

To test:

1. Go to the OPAC homepage
2. Use an accessibility tool (e.g Chrome's
   Lighthouse tool) to check the contrast ratio
3. Confirm that the clear search history link
   has insufficient contrast
4. Apply the patch and rebuild css:
   yarn build --view opac
5. Confirm that the contrast ratio now
   meets minimum accessibility requirements
6. Check the OPAC still looks ok after the changes

Comment 2 Owen Leonard 2021-09-21 10:30:14 UTC

Created attachment 125089 [details] [review]
Bug 29065: Accessibility OPAC clear search history link has insufficient contrast

This patch changes the colour of the clear search history link
on the OPAC to increase the contrast ratio, improve accessibility
and makes the text easier to read.

To test:

1. Go to the OPAC homepage
2. Use an accessibility tool (e.g Chrome's
   Lighthouse tool) to check the contrast ratio
3. Confirm that the clear search history link
   has insufficient contrast
4. Apply the patch and rebuild css:
   yarn build --view opac
5. Confirm that the contrast ratio now
   meets minimum accessibility requirements
6. Check the OPAC still looks ok after the changes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 3 Martin Renvoize (ashimema) 2021-09-24 15:37:33 UTC

Created attachment 125277 [details] [review]
Bug 29065: Accessibility OPAC clear search history link has insufficient contrast

This patch changes the colour of the clear search history link
on the OPAC to increase the contrast ratio, improve accessibility
and makes the text easier to read.

To test:

1. Go to the OPAC homepage
2. Use an accessibility tool (e.g Chrome's
   Lighthouse tool) to check the contrast ratio
3. Confirm that the clear search history link
   has insufficient contrast
4. Apply the patch and rebuild css:
   yarn build --view opac
5. Confirm that the contrast ratio now
   meets minimum accessibility requirements
6. Check the OPAC still looks ok after the changes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 4 Martin Renvoize (ashimema) 2021-09-24 15:38:37 UTC

Brill. PQA

Comment 5 Jonathan Druart 2021-09-28 13:39:46 UTC

Pushed to master for 21.11, thanks to everybody involved!

Comment 6 Kyle M Hall (khall) 2021-10-08 12:11:37 UTC

 Pushed to 21.05.x for 21.05.05