| Summary: | Hold expiration added to new holds when DefaultHoldExpirationdate turned off | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Hold requests | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05
|
|
| Circulation function: | |||
| Bug Depends on: | 26498 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate
Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate |
||
|
Description
Andrew Fuerste-Henry
2021-09-21 15:15:16 UTC
Created attachment 125111 [details] [review] Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate DefaultHldexpirationDate is set in the pref screen to 'yes/no' The code checks if the preference is 'true', 'no' is true We should instead use 1/0 To test: 0 - Have a fresh devbox 1 - With syspref disabled, place a hold 2 - Note no expiration date set 3 - Enable the preference 4 - Place a hold and note the expiration date is set, good 5 - Disable the pref 6 - Place a hold and note the expiration date is set, bad 7 - Apply patch 8 - Update database 9 - Repeat 1-8, date not set when pref disabled Created attachment 125113 [details] [review] Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate DefaultHldexpirationDate is set in the pref screen to 'yes/no' The code checks if the preference is 'true', 'no' is true We should instead use 1/0 To test: 0 - Have a fresh devbox 1 - With syspref disabled, place a hold 2 - Note no expiration date set 3 - Enable the preference 4 - Place a hold and note the expiration date is set, good 5 - Disable the pref 6 - Place a hold and note the expiration date is set, bad 7 - Apply patch 8 - Update database 9 - Repeat 1-8, date not set when pref disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 125264 [details] [review] Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate DefaultHldexpirationDate is set in the pref screen to 'yes/no' The code checks if the preference is 'true', 'no' is true We should instead use 1/0 To test: 0 - Have a fresh devbox 1 - With syspref disabled, place a hold 2 - Note no expiration date set 3 - Enable the preference 4 - Place a hold and note the expiration date is set, good 5 - Disable the pref 6 - Place a hold and note the expiration date is set, bad 7 - Apply patch 8 - Update database 9 - Repeat 1-8, date not set when pref disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Doh! Well spotted, Passing QA Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 |