| Summary: | OPAC info should not be displayed in libraries table | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | System Administration | Assignee: | Jérémy Breuillard <jeremy.breuillard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, jeremy.breuillard, jonathan.druart, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.06,20.11.12
|
|
| Circulation function: | |||
| Attachments: |
Bug 29075: 'OPAC info' removed in branches.pl
Bug 29075: 'OPAC info' removed in branches.pl Bug 29075: 'OPAC info' removed in branches.pl Bug 29075: 'OPAC info' removed in branches.pl Bug 29075: 'OPAC info' removed in branches.pl Bug 29075: 'OPAC info' removed in branches.pl |
||
|
Description
Fridolin Somers
2021-09-21 22:03:31 UTC
Created attachment 126975 [details] [review] Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone here and in opac-library.pl Created attachment 126987 [details] [review] Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone Created attachment 126994 [details] [review] Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone Created attachment 126996 [details] [review] Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone Created attachment 127072 [details] [review] Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone Signed-off-by: Owen <oleonard@myacpl.org> I think this patch makes good sense, but it does raise the question: Why don't we have a "view" page for libraries? That would be the logical place to put all the information we store about libraries. It might even be useful to have that page accessible to all staff. Created attachment 127127 [details] [review] Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone Signed-off-by: Owen <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Owen Leonard from comment #6) > I think this patch makes good sense, but it does raise the question: Why > don't we have a "view" page for libraries? That would be the logical place > to put all the information we store about libraries. It might even be useful > to have that page accessible to all staff. I am also in favor of this change - OPAC info doesn't really belong in the address column anyway. I am not sure about the view page concect as I think we only have this for suggestions so far but it could be something to look into. Another option might be a preview button like we have for news entries. Pushed to master for 21.11, thanks to everybody involved! Will be in 21.05.06 Pushed to 20.11.x for 20.11.12 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |