| Summary: | Placing holds via SIP2 does not check if a patron can hold the given item | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | SIP2 | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arthur.suzuki, david, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes holds placed using SIP2 to check that the patron can actually place a hold for the item.
|
Version(s) released in: |
22.11.00, 22.05.05
|
| Circulation function: | |||
| Attachments: |
Bug 29094: Adding hold via SIP should check if patron can hold item first
Bug 29094: Adding hold via SIP should check if patron can hold item first Bug 29094: Adding hold via SIP should check if patron can hold item first Bug 29094: Adding hold via SIP should check if patron can hold item first Bug 29094: Adding hold via SIP should check if patron can hold item first [21.11.x] |
||
|
Description
Kyle M Hall (khall)
2021-09-23 12:20:19 UTC
Created attachment 125189 [details] [review] Bug 29094: Adding hold via SIP should check if patron can hold item first When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP The patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29094: Adding hold via SIP should check if patron can hold item first Using index info to reconstruct a base tree... M t/db_dependent/SIP/ILS.t M t/db_dependent/SIP/Transaction.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/SIP/Transaction.t CONFLICT (content): Merge conflict in t/db_dependent/SIP/Transaction.t Auto-merging t/db_dependent/SIP/ILS.t error: Failed to merge in the changes. Patch failed at 0001 Bug 29094: Adding hold via SIP should check if patron can hold item first Created attachment 136570 [details] [review] Bug 29094: Adding hold via SIP should check if patron can hold item first When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Created attachment 136611 [details] [review] Bug 29094: Adding hold via SIP should check if patron can hold item first When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind <david@davidnind.com> Created attachment 137706 [details] [review] Bug 29094: Adding hold via SIP should check if patron can hold item first When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Thanks Kyle, Works as described, contains unit tests and QA scripts are all happy. Passing QA Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.05 Patch applies with conflicts + tests failing. Please provide a patch for 21.11 if needed. " # Failed test 'do_hold' # at t/db_dependent/SIP/Transaction.t line 272. DBIx::Class::ResultSource::_minimal_valueset_satisfying_constraint(): Unable to satisfy requested constraint 'primary', missing values for column(s): 'itemnumber' at /kohadevbox/koha/Koha/Objects.pm line 96 # Looks like your test exited with 11 just after 7. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 6/12 subtests " Created attachment 139830 [details] [review] Bug 29094: Adding hold via SIP should check if patron can hold item first [21.11.x] When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> |