|
Description
Joonas Kylmälä
2021-09-26 07:24:48 UTC
Created attachment 125311 [details] [review] Bug 29111: Remove dead code from acqui/addorderiso2709.pl Test plan: 1) open acqui/addorderiso2709.pl in your code editor and make sure nothing references $item in the if block where it was removed from Created attachment 125312 [details] [review] Bug 29111: Remove unused indicator modification code for items The indicator value for 952 was hard coded in every case to " ". In order to achieve that we can simply pass undef to TransformHtmlToXml() and it will set the indicator values to " ". To test: 1) Make sure the submission of (at least some) the modified files still work, e.g. test that making a new item via cataloguing/additem.pl works. Created attachment 125313 [details] [review] Bug 29111: Remove unused function from cataloguing/additem.pl To test: 1) Open cataloguing/additem.pl and search for any usages of find_value, you should find 0 usages. There was some additional dead code around the indicator values so those are removed here as well. Created attachment 125601 [details] [review] Bug 29111: Remove dead code from acqui/addorderiso2709.pl Test plan: 1) open acqui/addorderiso2709.pl in your code editor and make sure nothing references $item in the if block where it was removed from Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 125602 [details] [review] Bug 29111: Remove unused indicator modification code for items The indicator value for 952 was hard coded in every case to " ". In order to achieve that we can simply pass undef to TransformHtmlToXml() and it will set the indicator values to " ". To test: 1) Make sure the submission of (at least some) the modified files still work, e.g. test that making a new item via cataloguing/additem.pl works. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 125603 [details] [review] Bug 29111: Remove unused function from cataloguing/additem.pl To test: 1) Open cataloguing/additem.pl and search for any usages of find_value, you should find 0 usages. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> I've also tested the ordering, receiving, adding and batch modifying items in cataloguing and adding items from the serial module. Created attachment 125652 [details] [review] Bug 29111: Remove dead code from acqui/addorderiso2709.pl Test plan: 1) open acqui/addorderiso2709.pl in your code editor and make sure nothing references $item in the if block where it was removed from Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 125653 [details] [review] Bug 29111: Remove unused indicator modification code for items The indicator value for 952 was hard coded in every case to " ". In order to achieve that we can simply pass undef to TransformHtmlToXml() and it will set the indicator values to " ". To test: 1) Make sure the submission of (at least some) the modified files still work, e.g. test that making a new item via cataloguing/additem.pl works. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 125654 [details] [review] Bug 29111: Remove unused function from cataloguing/additem.pl To test: 1) Open cataloguing/additem.pl and search for any usages of find_value, you should find 0 usages. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Comment on attachment 125654 [details] [review] Bug 29111: Remove unused function from cataloguing/additem.pl Done on bug 27526 (Adjust code to use Koha::Items), obsoleting. Does not apply on top of bug 27526. At first glance I'd say that the changes to additem are no longer valid (I cleaned them already). Created attachment 125996 [details] [review] Bug 29111: Remove dead code from acqui/addorderiso2709.pl Test plan: 1) open acqui/addorderiso2709.pl in your code editor and make sure nothing references $item in the if block where it was removed from Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 125997 [details] [review] Bug 29111: Remove unused indicator modification code for items The indicator value for 952 was hard coded in every case to " ". In order to achieve that we can simply pass undef to TransformHtmlToXml() and it will set the indicator values to " ". To test: 1) Make sure the submission of (at least some) the modified files still work, e.g. test that making a new item via cataloguing/additem.pl works. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased-by: Joonas Kylmälä <joonas.kylmala@iki.fi> (In reply to Jonathan Druart from comment #13) > Does not apply on top of bug 27526. At first glance I'd say that the changes > to additem are no longer valid (I cleaned them already). Rebased. Pushed to master for 21.11, thanks to everybody involved! |