Description
Lucas Gass (lukeg)
2021-09-27 20:15:07 UTC
Created attachment 125378 [details] [review] Bug 29128: Remove whitespace in browse shelf link To test: -Turn on OPACShelfBrowser and make sure you have some itemcallnumbers -Go to detail page and see the link: (Browse shelf ) -Apply patch and look at the link again, it should be: (Browse shelf) Created attachment 125407 [details] [review] Bug 29128: Remove whitespace in browse shelf link To test: -Turn on OPACShelfBrowser and make sure you have some itemcallnumbers -Go to detail page and see the link: (Browse shelf ) -Apply patch and look at the link again, it should be: (Browse shelf) Signed-off-by: Jeremy <jeremy.breuillard@biblibre.com> Created attachment 125408 [details] [review] Bug 29128 : Remove the other whitespace in browse shelf link Another occurence found and fixed Created attachment 125428 [details] [review] Bug 29128: Remove whitespace in browse shelf link To test: -Turn on OPACShelfBrowser and make sure you have some itemcallnumbers -Go to detail page and see the link: (Browse shelf ) -Apply patch and look at the link again, it should be: (Browse shelf) Signed-off-by: David Nind <david@davidnind.com> Created attachment 125429 [details] [review] Bug 29128 : Remove the other whitespace in browse shelf link Signed-off-by: David Nind <david@davidnind.com> (In reply to jeremy from comment #4) > Another occurence found and fixed Thanks Jeremy for fixing this! Created attachment 125483 [details] [review] Bug 29128: Remove whitespace in browse shelf link To test: -Turn on OPACShelfBrowser and make sure you have some itemcallnumbers -Go to detail page and see the link: (Browse shelf ) -Apply patch and look at the link again, it should be: (Browse shelf) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 125484 [details] [review] Bug 29128: Remove the other whitespace in browse shelf link Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice string fix.. PQA Created attachment 125693 [details] [review] Bug 29128: Remove the other whitespace in browse shelf link Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Adjusted patch's author, as agreed with Jeremy. Created attachment 125694 [details] [review] Bug 29128: Remove the other whitespace in browse shelf link Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed to master for 21.11, thanks to everybody involved! Congratulations for your first patch pushed, Jérémy! (In reply to Jonathan Druart from comment #15) > Congratulations for your first patch pushed, Jérémy! Thanks ! :) Pushed to 21.05.x for 21.05.05 |