| Summary: | The clear screen and print icons in circulation should be configurable to print either ISSUESLIP or ISSUEQSLIP | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | a.roussos, andrew, caroline.cyr-la-rose, fridolin.somers, gmcharlt, kyle.m.hall, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/616 |
| Text to go in the release notes: |
This enhancement expands upon the 'DisplayClearScreenButton' allowing the choice of printing either the ISSUESLIP or the ISSUEQSLIP when using the printclearscreen icon.
|
Version(s) released in: |
22.11.00
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 34684 | ||
| Attachments: |
Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip
Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip Bug 29129: (QA follow-up) Add +x to atomicupdate permissions Bug 29129: (QA follow-up): Fix tiny typo in system preference description Bug 29129: (QA follow-up) Rephrasing DisplayClearScreenButton preference Bug 29129: (QA follow-up) Tidy atomicupdate |
||
|
Description
Lucas Gass (lukeg)
2021-09-28 15:58:33 UTC
+! Created attachment 134175 [details] [review] Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip To Test: 1. Apply patch, updatedatabase, and restart_all 2. A small change the global scss file means you should regenerate the CSS as well. ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Set DisplayClearScreenButton to "don't show" 4. Go to the patron checkout screen and see that no button should show to clear the screen and print 5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now appears and the ISSUESLIP prints 6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now appears and the ISSUEQSLIP prints Created attachment 134176 [details] [review] Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip To Test: 1. Apply patch, updatedatabase, and restart_all 2. A small change the global scss file means you should regenerate the CSS as well. ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Set DisplayClearScreenButton to "don't show" 4. Go to the patron checkout screen and see that no button should show to clear the screen and print 5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now appears and the ISSUESLIP prints 6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now appears and the ISSUEQSLIP prints Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Please remember to run QA test tools: OK circ/circulation.pl FAIL installer/data/mysql/atomicupdate/bug29129.pl FAIL file permissions File must have the exec flag Created attachment 134282 [details] [review] Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip To Test: 1. Apply patch, updatedatabase, and restart_all 2. A small change the global scss file means you should regenerate the CSS as well. ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Set DisplayClearScreenButton to "don't show" 4. Go to the patron checkout screen and see that no button should show to clear the screen and print 5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now appears and the ISSUESLIP prints 6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now appears and the ISSUEQSLIP prints Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 134283 [details] [review] Bug 29129: (QA follow-up) Add +x to atomicupdate permissions Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 134284 [details] [review] Bug 29129: (QA follow-up): Fix tiny typo in system preference description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 134285 [details] [review] Bug 29129: (QA follow-up) Rephrasing DisplayClearScreenButton preference Trying to make it clearer that's either none or 2 buttons. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hi Lucas, maybe you can have a look at my last follow-up and let me know if that works for you? Why not always showing 3 buttons : CANCEL, ISSUESLIP, ISSUEQSLIP This will avoid a new system preference. (In reply to Fridolin Somers from comment #10) > Why not always showing 3 buttons : CANCEL, ISSUESLIP, ISSUEQSLIP > This will avoid a new system preference. I will rework this to just always show all 3, without a sys pref. (In reply to Lucas Gass from comment #11) > (In reply to Fridolin Somers from comment #10) > > Why not always showing 3 buttons : CANCEL, ISSUESLIP, ISSUEQSLIP > > This will avoid a new system preference. > > I will rework this to just always show all 3, without a sys pref. We already have the pref, so it's just a new option to an existing one. I feel that libraries have prefernces about the slips and we'd need really clear icons for full and quick slip printing. Not sure if that would not be worth to be discussed/done later and let this in as a small change to an already existing feature. > We already have the pref, so it's just a new option to an existing one.
>
Ohhh i totally missed that.
In this case OK to add a new option, sure
Created attachment 136551 [details] [review] Bug 29129: (QA follow-up) Tidy atomicupdate Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! Enhancement will not be backported to 22.05.x series unless requested |