| Summary: | Row striping breaks color coding on item circulation alerts | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle, lucas, oleonard, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05,20.11.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 29131: Row striping breaks color coding on item circulation alerts
Bug 29131: Row striping breaks color coding on item circulation alerts Bug 29131: Row striping breaks color coding on item circulation alerts |
||
Created attachment 125735 [details] [review] Bug 29131: Row striping breaks color coding on item circulation alerts The CSS we use for table row "striping," which uses 'tbody tr:nth-child(odd),' is often difficult to work with because it takes a lot of increased specificity to override the default. Bootstrap compounds this by adding its own similar CSS. In order to overcome this I've added '!important' to the CSS embedded in the item circulation alerts page. I normally would avoid '!important' but since this CSS is only relevant to this page I think it's appropriate. This patch also adds [% FILTER collapse %] around the <style> block and does some reindenting, so ignore whitespace when using diff to see the changes clearly. To test, apply the patch and go to Administration -> Item circulation alerts. - Check the "Legend" table. The first cells should be distinct colors: red, pink, and green. - In the "Checkout" table, table cells should be green by default. Clicking in one of the cells should turn it red with the text "Disabled for all." - Use the "Select a library" dropdown to pick a library. - Clicking in any green cell should turn the cell pink and add the text "Disabled for XXX" where XXX is the branchcode. Created attachment 125757 [details] [review] Bug 29131: Row striping breaks color coding on item circulation alerts The CSS we use for table row "striping," which uses 'tbody tr:nth-child(odd),' is often difficult to work with because it takes a lot of increased specificity to override the default. Bootstrap compounds this by adding its own similar CSS. In order to overcome this I've added '!important' to the CSS embedded in the item circulation alerts page. I normally would avoid '!important' but since this CSS is only relevant to this page I think it's appropriate. This patch also adds [% FILTER collapse %] around the <style> block and does some reindenting, so ignore whitespace when using diff to see the changes clearly. To test, apply the patch and go to Administration -> Item circulation alerts. - Check the "Legend" table. The first cells should be distinct colors: red, pink, and green. - In the "Checkout" table, table cells should be green by default. Clicking in one of the cells should turn it red with the text "Disabled for all." - Use the "Select a library" dropdown to pick a library. - Clicking in any green cell should turn the cell pink and add the text "Disabled for XXX" where XXX is the branchcode. Signed-off-by: David Nind <david@davidnind.com> Created attachment 125766 [details] [review] Bug 29131: Row striping breaks color coding on item circulation alerts The CSS we use for table row "striping," which uses 'tbody tr:nth-child(odd),' is often difficult to work with because it takes a lot of increased specificity to override the default. Bootstrap compounds this by adding its own similar CSS. In order to overcome this I've added '!important' to the CSS embedded in the item circulation alerts page. I normally would avoid '!important' but since this CSS is only relevant to this page I think it's appropriate. This patch also adds [% FILTER collapse %] around the <style> block and does some reindenting, so ignore whitespace when using diff to see the changes clearly. To test, apply the patch and go to Administration -> Item circulation alerts. - Check the "Legend" table. The first cells should be distinct colors: red, pink, and green. - In the "Checkout" table, table cells should be green by default. Clicking in one of the cells should turn it red with the text "Disabled for all." - Use the "Select a library" dropdown to pick a library. - Clicking in any green cell should turn the cell pink and add the text "Disabled for XXX" where XXX is the branchcode. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.11 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |
To recreate: Browse to Administration->Item circulation alerts Note that 'Disabled for all' and 'Enabled' are the same color in the key Note that half the rows are gray Seems to be from: tbody tr:nth-child(odd):not(.dtrg-group):not(.active) td:not(.bg-danger):not(.bg-warning):not(.bg-info):not(.bg-success):not(.bg-primary) { background-color:#f9f9f9; }