Summary: | Patron search on request.pl has performance and display issues | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Hold requests | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | andrew, david, gmcharlt, jonathan.druart, kyle, martin.renvoize, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the performance and display of patron search results when placing a hold from a record details page using the staff interface. Patron results are now paginated and all the results are now available - previously all results were listed on one page, which could cause performance issues.
|
Version(s) released in: |
22.05.00
|
Circulation function: | |||
Bug Depends on: | 28782 | ||
Bug Blocks: | 30093 | ||
Attachments: |
Bug 29136: Ajaxify the patron search when placing a hold
Bug 29136: Don't redirect if the whole set is > 1 Bug 29136: Ajaxify the patron search when placing a hold Bug 29136: Don't redirect if the whole set is > 1 Bug 29136: Ajaxify the patron search when placing a hold Bug 29136: Don't redirect if the whole set is > 1 Bug 29136: (QA follow-up) missing filters Bug 29136: Ajaxify the patron search when placing a hold Bug 29136: Don't redirect if the whole set is > 1 Bug 29136: (QA follow-up) missing filters |
Description
Nick Clemens (kidclamp)
2021-09-29 17:55:43 UTC
If anybody is interested in this, please have a look at bug 15812 comment 37. IMO we shouldn't follow what has been done on bug 15812. Created attachment 130039 [details] [review] Bug 29136: Ajaxify the patron search when placing a hold Nick, would that work for you? Tested suing KTD. Noted this issue when testing: . Generate two or more pages of results - use a or e as the patron search term. . Clicking on 3 or Last results in: . koha_sip (koha_sip) patron being selected as the patron, and . being returned to the area to finish placing a hold . With only two pages of results (search for i) this doesn't occur. Test plan: 1. Search for a record in the staff interface. 2. Go the detail page for an item in the search results. 3. Click 'Place hold'. 4. In the patron search box enter an a or e. 5. Note that the results are unpaginated and all results that match are displayed on one page. 6. Apply the patch and repeat steps 1 to 5. 7. Note that the results are now paginated using the standard DataTables layout and features. 8. Check that everything works as expected: pagination, including Next, last, previous, each number; select columns; change number of results; export. 9. Sign off :D! Created attachment 130239 [details] [review] Bug 29136: Don't redirect if the whole set is > 1 To prevent a redirect when we click on a page with only 1 result Good catch, David. Thanks! Created attachment 130245 [details] [review] Bug 29136: Ajaxify the patron search when placing a hold Signed-off-by: David Nind <david@davidnind.com> Created attachment 130246 [details] [review] Bug 29136: Don't redirect if the whole set is > 1 To prevent a redirect when we click on a page with only 1 result Signed-off-by: David Nind <david@davidnind.com> Created attachment 130874 [details] [review] Bug 29136: Ajaxify the patron search when placing a hold Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 130875 [details] [review] Bug 29136: Don't redirect if the whole set is > 1 To prevent a redirect when we click on a page with only 1 result Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 130876 [details] [review] Bug 29136: (QA follow-up) missing filters Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 131355 [details] [review] Bug 29136: Ajaxify the patron search when placing a hold Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 131356 [details] [review] Bug 29136: Don't redirect if the whole set is > 1 To prevent a redirect when we click on a page with only 1 result Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 131357 [details] [review] Bug 29136: (QA follow-up) missing filters Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Jonathan, if you think this should be backported, can you please rebase to 21.11.x? If it's not needed, go head and set the bug to RESOLVED/FIXED. Thanks! (In reply to Kyle M Hall from comment #16) > Jonathan, if you think this should be backported, can you please rebase to > 21.11.x? If it's not needed, go head and set the bug to RESOLVED/FIXED. > Thanks! I don't think it should be backported, it's based on other bugs that are not in 21.11. |