Summary: | CodeMirror broken for news and HTML customizations | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Tools | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
Circulation function: | |||
Bug Depends on: | 24387 | ||
Bug Blocks: | |||
Attachments: |
Bug 29153: Fix CodeMirror textareas to work with all languages
Bug 29153: Fix CodeMirror textareas to work with all languages Bug 29153: Fix CodeMirror textareas to work with all languages |
Description
Lucas Gass (lukeg)
2021-10-01 17:00:32 UTC
Created attachment 126368 [details] [review] Bug 29153: Fix CodeMirror textareas to work with all languages To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, notice a console error. 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. Created attachment 126390 [details] [review] Bug 29153: Fix CodeMirror textareas to work with all languages To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, notice a console error. 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. Signed-off-by: David Nind <david@davidnind.com> Created attachment 126463 [details] [review] Bug 29153: Fix CodeMirror textareas to work with all languages To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, notice a console error. 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! |