Summary: | Can't use controlfields with CustomCoverImagesURL | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00,21.05.05,20.11.11
|
Circulation function: | |
Bug Depends on: | 22445 | ||
Bug Blocks: | |||
Attachments: |
Bug 29172: Make CustomCoverImagesURL compatible with control fields
Bug 29172: Make CustomCoverImagesURL compatible with control fields Bug 29172: Make CustomCoverImagesURL compatible with control fields Bug 29172: (follow-up) Amend preference text for control fields |
Description
Katrin Fischer
2021-10-05 09:57:41 UTC
Created attachment 125731 [details] [review] Bug 29172: Make CustomCoverImagesURL compatible with control fields Bug 22445 added CustomCoverImagesURL that deals with MARC fields, but control fields were not supported. Test plan: Turn CustomCoverImages on Fill CustomCoverImagesURL with https://covers.openlibrary.org/b/isbn/{006}-M.jpg Add an isbn in 006 (0596001738 will work) Go to the detail page of the bibliographic record and confirm that you see a cover image. Created attachment 125754 [details] [review] Bug 29172: Make CustomCoverImagesURL compatible with control fields Bug 22445 added CustomCoverImagesURL that deals with MARC fields, but control fields were not supported. Test plan: Turn CustomCoverImages on Fill CustomCoverImagesURL with https://covers.openlibrary.org/b/isbn/{006}-M.jpg Add an isbn in 006 (0596001738 will work) Go to the detail page of the bibliographic record and confirm that you see a cover image. Signed-off-by: David Nind <david@davidnind.com> Created attachment 126014 [details] [review] Bug 29172: Make CustomCoverImagesURL compatible with control fields Bug 22445 added CustomCoverImagesURL that deals with MARC fields, but control fields were not supported. Test plan: Turn CustomCoverImages on Fill CustomCoverImagesURL with https://covers.openlibrary.org/b/isbn/{006}-M.jpg Add an isbn in 006 (0596001738 will work) Go to the detail page of the bibliographic record and confirm that you see a cover image. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 126015 [details] [review] Bug 29172: (follow-up) Amend preference text for control fields Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.11 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |