| Summary: | Remove TODO in acqui/finishreceive.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | jonathan.druart, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29202 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 29202 | ||
| Attachments: |
Bug 29177: Remove TODO in acqui/finishreceive
Bug 29177: Remove TODO in acqui/finishreceive |
||
|
Description
Marcel de Rooy
2021-10-05 14:05:42 UTC
Created attachment 125738 [details] [review] Bug 29177: Remove TODO in acqui/finishreceive Replacing a multiple object->column(value) by ->update. Martin, did you have this in mind ? So trivial that I am signing off. Leaving for Martin. Created attachment 126035 [details] [review] Bug 29177: Remove TODO in acqui/finishreceive Replacing a multiple object->column(value) by ->update. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> A good improvement, all works as expected. It did lead me to ask the question "Should the replacementprice field have the same date trigger treatment as itemlost, damaged and withdrawn fields?" I think the answer is "yes", but I think that falls outside of the scope of this one, so I'm opening another bug and will link it here. Pushed to master for 21.11, thanks to everybody involved! |