Summary: | Highlighting broken on odd rows in circ-patron-search-results | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle, oleonard, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05,20.11.12
|
|
Circulation function: | |||
Attachments: |
Bug 29195: Fix highlighting on odd rows in circ-patron-search-results
Bug 29195: Fix highlighting on odd rows in circ-patron-search-results |
Description
Nick Clemens (kidclamp)
2021-10-08 13:28:17 UTC
The rule is overwritten in DT. Owen, is there a better way than using !important here? diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss index 44e2b32ae4e..260a96b9058 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss @@ -297,7 +297,7 @@ tr { tr { &:hover { td { - background-color: #FFFF99; + background-color: #FFFF99 !important; } } } This works. I was hoping this had been made obsolete by Bug 15812 but these results might still shown during the process of placing a hold. Do we go with the '!important'? Created attachment 127361 [details] [review] Bug 29195: Fix highlighting on odd rows in circ-patron-search-results This patch adds "!important" to the CSS rule governing the background color of table cells when hovered. It only applies to tables with the "selections-table" class. Although "!important" is not usually recommended, in this case the appliation is narrow enough that I think it outweighs the complicated selector that would be required to make it work otherwise. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a record in the catalog and being the process of placing a hold. - When you're asked to enter a card number or search by name, search using a name which will return multiple results. - In the table of results, hovering the mouse over the table should highlight the row in yellow. - Perform the same test when searching for a club by name. Created attachment 127362 [details] [review] Bug 29195: Fix highlighting on odd rows in circ-patron-search-results This patch adds "!important" to the CSS rule governing the background color of table cells when hovered. It only applies to tables with the "selections-table" class. Although "!important" is not usually recommended, in this case the appliation is narrow enough that I think it outweighs the complicated selector that would be required to make it work otherwise. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a record in the catalog and being the process of placing a hold. - When you're asked to enter a card number or search by name, search using a name which will return multiple results. - In the table of results, hovering the mouse over the table should highlight the row in yellow. - Perform the same test when searching for a club by name. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.12 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |