Summary: | Follow-up to Bug 27068 - Remove unnecessary check | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Hold requests | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | major | ||
Priority: | P5 - low | CC: | gmcharlt, joonas.kylmala, kyle, m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
22.11.00
|
Circulation function: | |
Attachments: |
Bug 29196: Bug 27068 follow-up
Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check Bug 29196: (Bug 27068 follow-up) - Remove unnecessary check Bug 29196: (Bug 27068 follow-up) - Remove unnecessary check |
Description
Nick Clemens (kidclamp)
2021-10-08 13:39:34 UTC
Created attachment 125963 [details] [review] Bug 29196: Bug 27068 follow-up Test plan stolen/updated from 27068 To test: 1) In library groups add a root group and check it as hold group. 2) Add two libraries to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold pickup library match change the value to 'From patron's hold group' 4) Place a hold from a patron whose home library is from the group 4.5) perl misc/cronjobs/holds/build_holdsqueue.pl 5) Go to /cgi-bin/koha/circ/view_holdsqueue.pl 6) Select the holding branch of the item with a hold 7) observe no results 8) Apply Patch 9) Repeat 5-6 10) The item should come up on the holds queue results 11) Place a hold on an item where 1 record has 2 copies, 1 in the hold group, 1 not. 12) Run the HoldQueue for the library not in the group and make sure the hold isn't showing. 13) Turn on transportation cost matrix and set costs for the libraries within the group. 14) Place a hold for a patron where multiple copies are on the bib. 15) Check both branch's hold queue for the item, it should only show on the lower cost branch's list if both copies are available. Nick and I talked about this. We are quite sure that line of code is superfluous and can be safely removed. *** Bug 29219 has been marked as a duplicate of this bug. *** Created attachment 126226 [details] [review] Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check The introduction of _checkHoldPolicy has made this check superfluous. Test Plan: 1) Apply this patch 2) prove t/db_dependent/HoldsQueue.t Created attachment 126788 [details] [review] Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check The introduction of _checkHoldPolicy has made this check superfluous. Test Plan: 1) Apply this patch 2) prove t/db_dependent/HoldsQueue.t Signed-off-by: David Nind <david@davidnind.com> Kyle, please provide unit tests for the 'holdgroup' and 'patrongroup' cases to highlight this bug and fix the commit message to describe the bug (so basically copy&paste the commit message from Nick's patch) Created attachment 140832 [details] [review] Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check The introduction of _checkHoldPolicy has made this check superfluous. Test plan stolen/updated from 27068 To test: 1) In library groups add a root group and check it as hold group. 2) Add two libraries to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold pickup library match change the value to 'From patron's hold group' 4) Place a hold from a patron whose home library is from the group 4.5) perl misc/cronjobs/holds/build_holdsqueue.pl 5) Go to /cgi-bin/koha/circ/view_holdsqueue.pl 6) Select the holding branch of the item with a hold 7) observe no results 8) Apply Patch 9) Repeat 5-6 10) The item should come up on the holds queue results 11) Place a hold on an item where 1 record has 2 copies, 1 in the hold group, 1 not. 12) Run the HoldQueue for the library not in the group and make sure the hold isn't showing. 13) Turn on transportation cost matrix and set costs for the libraries within the group. 14) Place a hold for a patron where multiple copies are on the bib. 15) Check both branch's hold queue for the item, it should only show on the lower cost branch's list if both copies are available. Signed-off-by: David Nind <david@davidnind.com> (In reply to Joonas Kylmälä from comment #6) > Kyle, please provide unit tests for the 'holdgroup' and 'patrongroup' cases > to highlight this bug and fix the commit message to describe the bug (so > basically copy&paste the commit message from Nick's patch) Are tests from 27068 not sufficient? * Commit title does not contain 'follow-up' correctly spelt - c61176ac2a Created attachment 141131 [details] [review] Bug 29196: (Bug 27068 follow-up) - Remove unnecessary check The introduction of _checkHoldPolicy has made this check superfluous. Test plan stolen/updated from 27068 To test: 1) In library groups add a root group and check it as hold group. 2) Add two libraries to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold pickup library match change the value to 'From patron's hold group' 4) Place a hold from a patron whose home library is from the group 4.5) perl misc/cronjobs/holds/build_holdsqueue.pl 5) Go to /cgi-bin/koha/circ/view_holdsqueue.pl 6) Select the holding branch of the item with a hold 7) observe no results 8) Apply Patch 9) Repeat 5-6 10) The item should come up on the holds queue results 11) Place a hold on an item where 1 record has 2 copies, 1 in the hold group, 1 not. 12) Run the HoldQueue for the library not in the group and make sure the hold isn't showing. 13) Turn on transportation cost matrix and set costs for the libraries within the group. 14) Place a hold for a patron where multiple copies are on the bib. 15) Check both branch's hold queue for the item, it should only show on the lower cost branch's list if both copies are available. Signed-off-by: David Nind <david@davidnind.com> Created attachment 141155 [details] [review] Bug 29196: (Bug 27068 follow-up) - Remove unnecessary check The introduction of _checkHoldPolicy has made this check superfluous. Test plan stolen/updated from 27068 To test: 1) In library groups add a root group and check it as hold group. 2) Add two libraries to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold pickup library match change the value to 'From patron's hold group' 4) Place a hold from a patron whose home library is from the group 4.5) perl misc/cronjobs/holds/build_holdsqueue.pl 5) Go to /cgi-bin/koha/circ/view_holdsqueue.pl 6) Select the holding branch of the item with a hold 7) observe no results 8) Apply Patch 9) Repeat 5-6 10) The item should come up on the holds queue results 11) Place a hold on an item where 1 record has 2 copies, 1 in the hold group, 1 not. 12) Run the HoldQueue for the library not in the group and make sure the hold isn't showing. 13) Turn on transportation cost matrix and set costs for the libraries within the group. 14) Place a hold for a patron where multiple copies are on the bib. 15) Check both branch's hold queue for the item, it should only show on the lower cost branch's list if both copies are available. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! |