| Summary: | replacementprice changes should trigger replacementpricedate updates | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Acquisitions | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | m.de.rooy, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29177 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 29177 | ||
| Bug Blocks: | |||
| Attachments: | Bug 29202: Trigger replacementpricedate on replacementprice change | ||
|
Description
Martin Renvoize (ashimema)
2021-10-11 09:31:53 UTC
Created attachment 126037 [details] [review] Bug 29202: Trigger replacementpricedate on replacementprice change my @fields = qw( itemlost withdrawn damaged replacementprice );
for my $field (@fields) {
[...]
my $field_on = "${field}_on";
$self->$field_on(undef);
This will not work for replacementprice ;)
No _on there
Btw I have my doubts here if the code does exactly what we want here. We only want a updated timestamp if the value actually changes.
Is the finishreceive script the only passing this value?
We need some tests !
I've decided this is invalid.. :-) |