Bug 29219

Summary: Suppress warning when building holds queue where hold fulfillment policy is 'patrongroup'
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: Hold requestsAssignee: Kyle M Hall (khall) <kyle>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 29219: Suppress warning when building holds queue where hold fulfillment policy is 'patrongroup'

Description Kyle M Hall (khall) 2021-10-13 12:22:41 UTC
When building the holds queue with rules where the hold fulfillment policy is 'patrongroup', you may see the following warning:

Use of uninitialized value in string eq at /usr/share/koha/lib/C4/HoldsQueue.pm line 728.

because there is not such thing as a 'patrongroup' key for the item hash.
Comment 1 Kyle M Hall (khall) 2021-10-13 12:24:32 UTC
Created attachment 126180 [details] [review]
Bug 29219: Suppress warning when building holds queue where hold fulfillment policy is 'patrongroup'

When building the holds queue with rules where the hold fulfillment policy is 'patrongroup', you may see the following warning:

Use of uninitialized value in string eq at /usr/share/koha/lib/C4/HoldsQueue.pm line 728.

because there is not such thing as a 'patrongroup' key for the item hash.

Test Plan:
1) Set hold rules to use patrongroup
2) Build the holds queue
3) Note the warning
4) Apply this patch
5) Build the holds queue again
6) No warning!
Comment 2 Kyle M Hall (khall) 2021-10-13 15:29:10 UTC

*** This bug has been marked as a duplicate of bug 29196 ***