Summary: | Report subgroup does not appear consistently | ||
---|---|---|---|
Product: | Koha | Reporter: | Donna <bwsdonna> |
Component: | Reports | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle, nick, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00,21.05.05,20.11.11
|
Circulation function: | |
Bug Depends on: | 24958 | ||
Bug Blocks: | |||
Attachments: |
Bug 29225: Don't hide subgroup filter on pag load
Bug 29225: Don't hide subgroup filter on pag load Bug 29225: Don't hide subgroup filter on pag load |
Description
Donna
2021-10-13 15:27:18 UTC
Created attachment 126276 [details] [review] Bug 29225: Don't hide subgroup filter on pag load When we auto select the last used tab, we hit code that hides the Subgroup dropdown Clicking to other tabs shows the dropdown again There is code on the tab selection to hide subgroups on the 'All' tab, the other line seems superfluous To test: 1 - Create a report and assign a group and subgroup, creating if necessary 2 - Browse to "Reports->Use saved" 3 - Click on the tab for the report you just created, see the subgroups dropdown 4 - Reload the page, Subgroups dropdown disappears 5 - Apply patch 6 - Relaod the page 7 - It's back! 8 - Confirm dropdown filters as expected Created attachment 126278 [details] [review] Bug 29225: Don't hide subgroup filter on pag load When we auto select the last used tab, we hit code that hides the Subgroup dropdown Clicking to other tabs shows the dropdown again There is code on the tab selection to hide subgroups on the 'All' tab, the other line seems superfluous To test: 1 - Create a report and assign a group and subgroup, creating if necessary 2 - Browse to "Reports->Use saved" 3 - Click on the tab for the report you just created, see the subgroups dropdown 4 - Reload the page, Subgroups dropdown disappears 5 - Apply patch 6 - Relaod the page 7 - It's back! 8 - Confirm dropdown filters as expected Signed-off-by: Donna <donna@bywatersolutions.com> Good catch! Created attachment 126621 [details] [review] Bug 29225: Don't hide subgroup filter on pag load When we auto select the last used tab, we hit code that hides the Subgroup dropdown Clicking to other tabs shows the dropdown again There is code on the tab selection to hide subgroups on the 'All' tab, the other line seems superfluous To test: 1 - Create a report and assign a group and subgroup, creating if necessary 2 - Browse to "Reports->Use saved" 3 - Click on the tab for the report you just created, see the subgroups dropdown 4 - Reload the page, Subgroups dropdown disappears 5 - Apply patch 6 - Relaod the page 7 - It's back! 8 - Confirm dropdown filters as expected Signed-off-by: Donna <donna@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.11 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |