Bug 29227

Summary:	Patron messaging preferences digest show as editable but are not
Product:	Koha	Reporter:	Donna <bwsdonna>
Component:	Patrons	Assignee:	Nick Clemens (kidclamp) <nick>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, kyle, nick, victor
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	21.11.00,21.05.05,20.11.12
Circulation function:
Bug Depends on:	13613
Bug Blocks:
Attachments:	Bug 29227: Patron messaging preferences digest show as editable but are not Bug 29227: Patron messaging preferences digest show as editable but are not Bug 29227: Patron messaging preferences digest show as editable but are not

Description Donna 2021-10-13 15:40:28 UTC

Go to members/moremember.pl for a patron who has messaging preferences set.  

Notice in the messaging preferences that the digest column displays as active (showing either the blue checkmark or a white box).

Click on one of the digests and see that you can change it (which is bad).

Navigate away from the page, return to it, and see that changes are not reflected (which is good)

This column should not be active/appear to be editable from this screen - it should only be editable through the modification screens like the rest of the preferences in the table.

Comment 1 Nick Clemens (kidclamp) 2021-10-14 12:07:14 UTC

Created attachment 126275 [details] [review]
Bug 29227: Patron messaging preferences digest show as editable but are not

On moremember.pl we load the messaging preferences for display only, we do
not need to load the JS for editing the preferences

To test:
0 - Enable EnhancedMessagingPreferences
1 - Load the detais tab for a member
2 - Note the digest column in messaging preferences is clickable
3 - Apply patch
4 - Reload, it is not clickable
5 - Confirm editing the patron (or their messaging prefs) works as expected

Comment 2 David Nind 2021-10-15 08:28:29 UTC

Created attachment 126310 [details] [review]
Bug 29227: Patron messaging preferences digest show as editable but are not

On moremember.pl we load the messaging preferences for display only, we do
not need to load the JS for editing the preferences

To test:
0 - Enable EnhancedMessagingPreferences
1 - Load the detais tab for a member
2 - Note the digest column in messaging preferences is clickable
3 - Apply patch
4 - Reload, it is not clickable
5 - Confirm editing the patron (or their messaging prefs) works as expected

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Katrin Fischer 2021-10-24 11:05:35 UTC

Created attachment 126803 [details] [review]
Bug 29227: Patron messaging preferences digest show as editable but are not

On moremember.pl we load the messaging preferences for display only, we do
not need to load the JS for editing the preferences

To test:
0 - Enable EnhancedMessagingPreferences
1 - Load the detais tab for a member
2 - Note the digest column in messaging preferences is clickable
3 - Apply patch
4 - Reload, it is not clickable
5 - Confirm editing the patron (or their messaging prefs) works as expected

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Jonathan Druart 2021-10-25 13:58:55 UTC

Pushed to master for 21.11, thanks to everybody involved!

Comment 5 Kyle M Hall (khall) 2021-10-29 13:40:48 UTC

Pushed to 21.05.x for 21.05.05

Comment 6 Fridolin Somers 2021-11-10 23:37:16 UTC

Pushed to 20.11.x for 20.11.12

Comment 7 Victor Grousset/tuxayo 2021-11-15 04:38:55 UTC

Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.