Summary: | PrepareItemrecordDisplay should not be called with empty string in defaultvalues | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05
|
|
Bug Depends on: | 27545 | ||
Bug Blocks: | |||
Attachments: |
Bug 29243: Correct call when adding items from staged records
Bug 29243: Correct call when adding items from staged records Bug 29243: Correct call when adding items from staged records |
Description
Nick Clemens
2021-10-14 11:21:33 UTC
Created attachment 126271 [details] [review] Bug 29243: Correct call when adding items from staged records To test: 1 - Populate system preference NewItemsDefaultLocation 2 - Stage a file of marc records 3 - Create an acquisitions basket with 'AcqCreateItems' set to 'ordering' 4 - Attempt to add to basket from your staged file 5 - You get a 500 error, and in the logs: Can't use string ("") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Items.pm line 1605. 6 - Apply patch 7 - Repeat #4 8 - Success! Created attachment 126297 [details] [review] Bug 29243: Correct call when adding items from staged records To test: 1 - Populate system preference NewItemsDefaultLocation 2 - Stage a file of marc records 3 - Create an acquisitions basket with 'AcqCreateItems' set to 'ordering' 4 - Attempt to add to basket from your staged file 5 - You get a 500 error, and in the logs: Can't use string ("") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Items.pm line 1605. 6 - Apply patch 7 - Repeat #4 8 - Success! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 126311 [details] [review] Bug 29243: Correct call when adding items from staged records To test: 1 - Populate system preference NewItemsDefaultLocation 2 - Stage a file of marc records 3 - Create an acquisitions basket with 'AcqCreateItems' set to 'ordering' 4 - Attempt to add to basket from your staged file 5 - You get a 500 error, and in the logs: Can't use string ("") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Items.pm line 1605. 6 - Apply patch 7 - Repeat #4 8 - Success! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Clear patch, works as expected. QA Scripts are happy. Passing QA Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 |