Bug 29246

Summary: We should rename the prefs 'template' and opacthemes
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: System AdministrationAssignee: Bugs List <koha-bugs>
Status: CLOSED WONTFIX QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 29246: Rename pref template between single quotes
Bug 29246: Fix order of installer/data/mysql/mandatory/sysprefs.sql
Bug 29246: Fix two incorrect calls of getTranslatedLanguages
Bug 29246: Rename pref template between double quotes
Bug 29246: Atomic update for db rev

Description Marcel de Rooy 2021-10-15 07:43:24 UTC
pref template is confusing; note that we have opacthemes too

In one run we might even adjust opacthemes to opactheme.
Comment 1 Marcel de Rooy 2021-10-25 13:13:34 UTC
Created attachment 126828 [details] [review]
Bug 29246: Rename pref template between single quotes

Result of git grep -l "'template'" ':!*.po' | \
    xargs sed -i -e "s/'template'/'intranet_theme'/g"

Excluding:
git checkout -- C4/Biblio.pm
git checkout -- Koha/Club/Enrollment.pm
git checkout -- Koha/Club/Enrollment/Field.pm
git checkout -- Koha/Club/Template.pm
git checkout -- Koha/Plugins/Base.pm
git checkout -- Koha/Template/Plugin/Cache.pm
git checkout -- catalogue/ISBDdetail.pl
git checkout -- koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt
git checkout -- koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
git checkout -- labels/label-manage.pl
git checkout -- opac/opac-ISBDdetail.pl
git checkout -- opac/opac-downloadcart.pl
git checkout -- opac/opac-downloadshelf.pl
git checkout -- opac/opac-export.pl
git checkout -- patroncards/manage.pl
git checkout -- t/db_dependent/Illrequests.t
Comment 2 Marcel de Rooy 2021-10-25 13:13:37 UTC
Created attachment 126829 [details] [review]
Bug 29246: Fix order of installer/data/mysql/mandatory/sysprefs.sql
Comment 3 Marcel de Rooy 2021-10-25 13:13:41 UTC
Created attachment 126830 [details] [review]
Bug 29246: Fix two incorrect calls of getTranslatedLanguages

memberentry and letter.pl refer to OPAC with the wrong theme.
Comment 4 Marcel de Rooy 2021-10-25 13:13:44 UTC
Created attachment 126831 [details] [review]
Bug 29246: Rename pref template between double quotes

Result of
git grep -l "\"template\"" ':!*.po' ':!*.js'  | \
    xargs sed -i -e "s/\"template\"/\"intranet_theme\"/g"

Excluding:
git checkout --  Koha/Schema/Result/MarcModificationTemplateAction.pm
Comment 5 Marcel de Rooy 2021-10-25 13:13:48 UTC
Created attachment 126832 [details] [review]
Bug 29246: Atomic update for db rev
Comment 6 Marcel de Rooy 2021-10-25 13:14:15 UTC
Still work in progress
Comment 7 Marcel de Rooy 2021-12-17 08:52:59 UTC
See bug 29245. Abandoning.