Bug 29270

Summary: Use flatpickr and futuredate on reserve/request.tt
Product: Koha Reporter: Jonathan Druart <jonathan.druart+koha>
Component: TemplatesAssignee: Jonathan Druart <jonathan.druart+koha>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, kyle, martin.renvoize, oleonard
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229
Change sponsored?: --- Patch complexity: Small patch
Text to go in the release notes:
Version(s) released in:
21.11.00
Bug Depends on: 29241    
Bug Blocks: 29394    
Attachments: Bug 29270: Remove flatpickr instantiation from request.tt
Bug 29270: Remove flatpickr instantiation from request.tt
Bug 29270: Remove flatpickr instantiation from request.tt
Bug 29270: Expiration date must be in future
Bug 29270: start_for is actually date_to

Description Jonathan Druart 2021-10-19 12:11:59 UTC
This template is initiating the flatpickr instance from the template file, it should not.
Comment 1 Jonathan Druart 2021-10-19 12:17:50 UTC
Created attachment 126496 [details] [review]
Bug 29270: Remove flatpickr instantiation from request.tt

The JS code is only used when placing a hold for club BUT the date
inputs are not displayed there.

Test plan:
Place holds for patrons and clubs and confirm that the two date inputs
are working correctly
Comment 2 David Nind 2021-10-21 18:55:43 UTC
Created attachment 126680 [details] [review]
Bug 29270: Remove flatpickr instantiation from request.tt

The JS code is only used when placing a hold for club BUT the date
inputs are not displayed there.

Test plan:
Place holds for patrons and clubs and confirm that the two date inputs
are working correctly

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2021-10-24 10:17:08 UTC
Created attachment 126796 [details] [review]
Bug 29270: Remove flatpickr instantiation from request.tt

The JS code is only used when placing a hold for club BUT the date
inputs are not displayed there.

Test plan:
Place holds for patrons and clubs and confirm that the two date inputs
are working correctly

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2021-10-25 13:59:06 UTC
Pushed to master for 21.11, thanks to everybody involved!
Comment 5 Jonathan Druart 2021-11-17 08:04:10 UTC
Created attachment 127706 [details] [review]
Bug 29270: Expiration date must be in future
Comment 6 Jonathan Druart 2021-11-17 08:05:52 UTC
(In reply to Jonathan Druart from comment #5)
> Created attachment 127706 [details] [review] [review]
> Bug 29270: Expiration date must be in future

Pushed to master.
Comment 7 Jonathan Druart 2021-11-17 08:34:26 UTC
Created attachment 127708 [details] [review]
Bug 29270: start_for is actually date_to

The attribute has been renamed in the meanwhile..
Comment 8 Jonathan Druart 2021-11-17 08:36:20 UTC
(In reply to Jonathan Druart from comment #7)
> Created attachment 127708 [details] [review] [review]
> Bug 29270: start_for is actually date_to
> 
> The attribute has been renamed in the meanwhile..

Pushed to master.