| Summary: | Replace the use of jQueryUI tabs on item circulation alerts page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle, lucas, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 29226, 29998, 29999, 30000, 30227, 30316, 30317 | ||
| Attachments: |
Bug 29277: Replace the use of jQueryUI tabs on item circulation alerts page
Bug 29277: Replace the use of jQueryUI tabs on item circulation alerts page Bug 29277: Replace the use of jQueryUI tabs on item circulation alerts page Screenshot with patch |
||
|
Description
Owen Leonard
2021-10-19 15:03:32 UTC
Created attachment 129696 [details] [review] Bug 29277: Replace the use of jQueryUI tabs on item circulation alerts page This patch replaces jQueryUI tabs on the item circulation alerts page as a simple example to start the process of switching how we implement tabbed interfaces. The patch bumps the Bootstrap version from 3.3.7 to 3.4.1 and adds the tabs component. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Item circulation alerts. - Confirm that the "Checkout" and "Check-in" tabs look correct and work correctly. Created attachment 129714 [details] [review] Bug 29277: Replace the use of jQueryUI tabs on item circulation alerts page This patch replaces jQueryUI tabs on the item circulation alerts page as a simple example to start the process of switching how we implement tabbed interfaces. The patch bumps the Bootstrap version from 3.3.7 to 3.4.1 and adds the tabs component. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Item circulation alerts. - Confirm that the "Checkout" and "Check-in" tabs look correct and work correctly. Signed-off-by: David Nind <david@davidnind.com> Before: https://snipboard.io/HLlery.jpg After : https://snipboard.io/gjpMyc.jpg We are loosing some borders and the tabs are less obvious. Is that expected? (In reply to Jonathan Druart from comment #3) > We are loosing some borders and the tabs are less obvious. Is that expected? No, I think you are seeing cached CSS. Please clear the browser cache and try again. Created attachment 130061 [details] [review] Bug 29277: Replace the use of jQueryUI tabs on item circulation alerts page This patch replaces jQueryUI tabs on the item circulation alerts page as a simple example to start the process of switching how we implement tabbed interfaces. The patch bumps the Bootstrap version from 3.3.7 to 3.4.1 and adds the tabs component. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Item circulation alerts. - Confirm that the "Checkout" and "Check-in" tabs look correct and work correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Owen Leonard from comment #4) > (In reply to Jonathan Druart from comment #3) > > > We are loosing some borders and the tabs are less obvious. Is that expected? > > No, I think you are seeing cached CSS. Please clear the browser cache and > try again. Indeed! It was sticky! Created attachment 130479 [details]
Screenshot with patch
Indeed it works after a refresh of browser cache.
Here is a screenshot.
Pushed to master for 22.05, thanks to everybody involved [U+1F984] |
