|
Description
Tomás Cohen Arazi (tcohen)
2021-10-20 21:01:04 UTC
Created attachment 126614 [details] [review] Bug 29288: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 126615 [details] [review] Bug 29288: Add current_checkouts and old_checkouts methods to Koha::Biblio This patch adds helper methods for accessing current and past checkouts for a given Koha::Biblio object. To test: 1. Apply the unit tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => FAIL: Methods are not implemented 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 126629 [details] [review] Bug 29288: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 126630 [details] [review] Bug 29288: Add current_checkouts and old_checkouts methods to Koha::Biblio This patch adds helper methods for accessing current and past checkouts for a given Koha::Biblio object. To test: 1. Apply the unit tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => FAIL: Methods are not implemented 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 126642 [details] [review] Bug 29288: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 126643 [details] [review] Bug 29288: Add current_checkouts and old_checkouts methods to Koha::Biblio This patch adds helper methods for accessing current and past checkouts for a given Koha::Biblio object. To test: 1. Apply the unit tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => FAIL: Methods are not implemented 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I wondered if there was any way to do this directly with relations, but it appears not. As such, it's looking good and works as expected.. Passing QA Created attachment 126973 [details] [review] Bug 29288: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 126974 [details] [review] Bug 29288: Add current_checkouts and old_checkouts methods to Koha::Biblio This patch adds helper methods for accessing current and past checkouts for a given Koha::Biblio object. To test: 1. Apply the unit tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => FAIL: Methods are not implemented 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Rebased on top of bug 14957. Pushed to master for 21.11, thanks to everybody involved! |