Summary: | 'Show fines to guarantor' should have its own id on patron detail page | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | barbara.johnson, jonathan.druart, kyle, nugged |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page
Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page |
Description
Katrin Fischer
2021-10-20 21:02:19 UTC
+1 Created attachment 127493 [details] [review] Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page This patch adds an id attribute to the list item containing the "Show fines to guarantor" information on the patron detail page in the staff interface. This makes it consistent with the markup for the similar "Show checkouts to guarantor" list item. To test, apply the patch and view a patron's details in the staff client. Inspect the source to confirm that the "Show fines to guarantor" line has an id, "patron-privacy_guarantor_fines". Alternatively, add this to the IntranetUserCSS system preference: #patron-privacy_guarantor_fines { background-color: pink; } The line on the patron details page should be highlighted in pink. Created attachment 127494 [details] [review] Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page This patch adds an id attribute to the list item containing the "Show fines to guarantor" information on the patron detail page in the staff interface. This makes it consistent with the markup for the similar "Show checkouts to guarantor" list item. To test, apply the patch and view a patron's details in the staff client. Inspect the source to confirm that the "Show fines to guarantor" line has an id, "patron-privacy_guarantor_fines". Alternatively, add this to the IntranetUserCSS system preference: #patron-privacy_guarantor_fines { background-color: pink; } The line on the patron details page should be highlighted in pink. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> <li id="patron-privacyguarantor"> <li id="patron-privacy_guarantor_fines"> That's inconsistent... Not blocker however. Created attachment 128467 [details] [review] Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page This patch adds an id attribute to the list item containing the "Show fines to guarantor" information on the patron detail page in the staff interface. This makes it consistent with the markup for the similar "Show checkouts to guarantor" list item. To test, apply the patch and view a patron's details in the staff client. Inspect the source to confirm that the "Show fines to guarantor" line has an id, "patron-privacy_guarantor_fines". Alternatively, add this to the IntranetUserCSS system preference: #patron-privacy_guarantor_fines { background-color: pink; } The line on the patron details page should be highlighted in pink. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |