| Summary: | Reindent serials search template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 29301 | ||
| Attachments: |
Bug 29299: Reindent serials search template
Bug 29299: (follow-up) Add markup comments Bug 29299: Reindent serials search template Bug 29299: (follow-up) Add markup comments Bug 29299: Reindent serials search template Bug 29299: (follow-up) Add markup comments |
||
|
Description
Owen Leonard
2021-10-21 11:32:35 UTC
Created attachment 126662 [details] [review] Bug 29299: Reindent serials search template This patch updates the serials search template to give it consistent indentation. The patch also moves one section of markup: The <tfoot> section is moved to after <tbody> in order to conform to current standards. To test, apply the patch and go to Serials -> Search subscriptions (in the header). - Serials search should work correctly and the page should look correct. - With Mana enabled, click on the "Search on Mana" link in the sidebar. - Searches of Mana should work correctly too. - If you view the diff while ignoring whitespace the only changes should be the move of <tfoot> and places where line breaks were introduced. Created attachment 126663 [details] [review] Bug 29299: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 126677 [details] [review] Bug 29299: Reindent serials search template This patch updates the serials search template to give it consistent indentation. The patch also moves one section of markup: The <tfoot> section is moved to after <tbody> in order to conform to current standards. To test, apply the patch and go to Serials -> Search subscriptions (in the header). - Serials search should work correctly and the page should look correct. - With Mana enabled, click on the "Search on Mana" link in the sidebar. - Searches of Mana should work correctly too. - If you view the diff while ignoring whitespace the only changes should be the move of <tfoot> and places where line breaks were introduced. Signed-off-by: David Nind <david@davidnind.com> Created attachment 126678 [details] [review] Bug 29299: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Created attachment 126798 [details] [review] Bug 29299: Reindent serials search template This patch updates the serials search template to give it consistent indentation. The patch also moves one section of markup: The <tfoot> section is moved to after <tbody> in order to conform to current standards. To test, apply the patch and go to Serials -> Search subscriptions (in the header). - Serials search should work correctly and the page should look correct. - With Mana enabled, click on the "Search on Mana" link in the sidebar. - Searches of Mana should work correctly too. - If you view the diff while ignoring whitespace the only changes should be the move of <tfoot> and places where line breaks were introduced. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 126799 [details] [review] Bug 29299: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! |