Summary: | Put 'other name' on checkout screen | ||
---|---|---|---|
Product: | Koha | Reporter: | David Schuster <dschust1> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | chris, dschust1, jcamins, jonathan.druart, mjr, paul.poulain, veron |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5172 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
patch for this bug - modifies circulation.pl and circulation.tmpl
Bug 2930 - Put other name on checkout screen Bug 2930 [REVISED] Put other name on checkout screen [SIGNED-OFF] Bug 2930 [REVISED] Put other name on checkout screen |
Description
Chris Cormack
2010-05-21 01:04:26 UTC
The attached patch makes a lot of changes not related to the bug description. The display name of the patron is generated in an include file now: [% IF category_type == 'I' %] [% surname %] [% IF othernames %] ([% othernames %]) [% END %] [% ELSE %] [% firstname %] [% surname %] [% END %] ([% cardnumber %]) So for an "organisation" the othername will already be displyed. How should the display for othername look like? Can we agree on something here? (In reply to comment #1) > So for an "organisation" the othername will already be displyed. How should > the display for othername look like? Can we agree on something here? I suspect it should be: [% firstname %] [% IF othernames %] ([% othernames %]) [% END %] [% surname %] Does anyone see a problem with that? It is one of the suggested forms in http://dictionary2.classic.reference.com/writing/styleguide/personal.html Created attachment 11783 [details] [review] Bug 2930 - Put other name on checkout screen This patch adds other name to the include which is used to display patron names and adds this include in several places where it can be used in place of direct output. The patron-title include has been modified to handle the two possible variable scopes throughout patron-related templates. This is a hack similar to having both circ-menu.tt and circ-menu.inc, but keeping both in the same file. Changes to some scripts were necessary to make the othernames variable available to the include. This patch also corrects some <title> tags and fixes some incorrect capitalization (see Bug 2780). To test, view each of the pages affected by these template changes and confirm that the patron's name displays correctly, including their "other name." This patch introduces a side-effect in the member results page. Links are not displayed. Marked as failed qa Created attachment 12021 [details] [review] Bug 2930 [REVISED] Put other name on checkout screen This patch adds other name to the include which is used to display patron names and adds this include in several places where it can be used in place of direct output. The patron-title include has been modified to handle the two possible variable scopes throughout patron-related templates. This is a hack similar to having both circ-menu.tt and circ-menu.inc, but keeping both in the same file. Changes to some scripts were necessary to make the othernames variable available to the include. This patch also corrects some <title> tags and fixes some incorrect capitalization (see Bug 2780). To test, view each of the pages affected by these template changes and confirm that the patron's name displays correctly, including their "other name." Created attachment 12321 [details] [review] [SIGNED-OFF] Bug 2930 [REVISED] Put other name on checkout screen This patch adds other name to the include which is used to display patron names and adds this include in several places where it can be used in place of direct output. The patron-title include has been modified to handle the two possible variable scopes throughout patron-related templates. This is a hack similar to having both circ-menu.tt and circ-menu.inc, but keeping both in the same file. Changes to some scripts were necessary to make the othernames variable available to the include. This patch also corrects some <title> tags and fixes some incorrect capitalization (see Bug 2780). To test, view each of the pages affected by these template changes and confirm that the patron's name displays correctly, including their "other name." Signed-off-by: Marc Veron <veron@veron.ch> Followed instructions above, works as expected. Hi Owen, Is it normal that your last patch uses the include file in only 1 tt file? I think your first proposed patch was more interesting, it used the include in several places instead of just one. What problem did you encounter? QA comment * small patch, template only * koha-qa.pl OK passed QA Patch pushed to master |