Bug 29306

Summary: Holds.t: Fix Use of uninitialized value $_ in concatenation (.) or string
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Test SuiteAssignee: Marcel de Rooy <m.de.rooy>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, kyle, victor
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:
21.11.00,21.05.05,20.11.12
Attachments: Bug 29306: Fix warning on undefined $_ in Holds.t
Bug 29306: Fix warning on undefined $_ in Holds.t

Description Marcel de Rooy 2021-10-22 08:17:02 UTC
Use of uninitialized value $_ in concatenation (.) or string at t/db_dependent/Holds.t line 1658.
            surname      => 'my surname ' . $_,

Pasted from another line within a loop
Comment 1 Marcel de Rooy 2021-10-22 08:20:36 UTC
Created attachment 126691 [details] [review]
Bug 29306: Fix warning on undefined $_ in Holds.t

Use of uninitialized value $_ in concatenation (.) or string at t/db_dependent/Holds.t line 1658.

Results from copying line 70.

Test plan:
Run Holds.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2021-10-22 08:20:56 UTC
So trivial. Self signoff
Comment 3 Katrin Fischer 2021-10-24 10:21:41 UTC
Created attachment 126797 [details] [review]
Bug 29306: Fix warning on undefined $_ in Holds.t

Use of uninitialized value $_ in concatenation (.) or string at t/db_dependent/Holds.t line 1658.

Results from copying line 70.

Test plan:
Run Holds.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2021-10-25 13:59:21 UTC
Pushed to master for 21.11, thanks to everybody involved!
Comment 5 Kyle M Hall 2021-10-29 13:39:28 UTC
Pushed to 21.05.x for 21.05.05
Comment 6 Fridolin Somers 2021-11-10 23:35:55 UTC
Pushed to 20.11.x for 20.11.12
Comment 7 Victor Grousset/tuxayo 2021-11-15 04:38:33 UTC
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.