Summary: | marc record fetched twice in detail.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, dcook, joonas.kylmala |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 29486 | ||
Bug Blocks: | |||
Attachments: |
Bug 29307: Remove unecessary marc record fetch on detail.pl
Bug 29307: Remove unecessary marc record fetch on detail.pl Bug 29307: Remove unecessary marc record fetch on detail.pl |
Description
Jonathan Druart
2021-10-22 09:41:17 UTC
Created attachment 126749 [details] [review] Bug 29307: Remove unecessary marc record fetch on detail.pl We were fetching the MARC::Record twice here. Created attachment 126791 [details] [review] Bug 29307: Remove unecessary marc record fetch on detail.pl We were fetching the MARC::Record twice here. Signed-off-by: David Nind <david@davidnind.com> Tested by checking that the MARC detail pages in the staff interface work as expected after the patch is applied. They don't do quite the same thing, GetMarcBiblio calls C4::Biblio::_koha_marc_update_bib_ids() and $biblio->metadata->record doesn't. (In reply to Joonas Kylmälä from comment #4) > They don't do quite the same thing, GetMarcBiblio calls > C4::Biblio::_koha_marc_update_bib_ids() and $biblio->metadata->record > doesn't. What differences do you expect? The point of those tests is to not explode later basically, so we must know if the record has a valid MARCXML stored in the biblio_metadata table. (In reply to Jonathan Druart from comment #5) > (In reply to Joonas Kylmälä from comment #4) > > They don't do quite the same thing, GetMarcBiblio calls > > C4::Biblio::_koha_marc_update_bib_ids() and $biblio->metadata->record > > doesn't. > > What differences do you expect? Commenting on this just based on the code I read: Before this patch the detail page included biblionumbers if they were not in the original data, after this patch it doesn't. (In reply to Joonas Kylmälä from comment #6) > (In reply to Jonathan Druart from comment #5) > > (In reply to Joonas Kylmälä from comment #4) > > > They don't do quite the same thing, GetMarcBiblio calls > > > C4::Biblio::_koha_marc_update_bib_ids() and $biblio->metadata->record > > > doesn't. > > > > What differences do you expect? > > Commenting on this just based on the code I read: Before this patch the > detail page included biblionumbers if they were not in the original data, > after this patch it doesn't. Yes, I don't think this call in GetMarcBiblio is relevant, I opened bug 29486. Created attachment 131864 [details] [review] Bug 29307: Remove unecessary marc record fetch on detail.pl We were fetching the MARC::Record twice here. Signed-off-by: David Nind <david@davidnind.com> |