Summary: | Punctuation: Total number of results: 961 (300 shown) . | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Reports | Assignee: | Séverine Queune <severine.queune> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | jonathan.druart, lucas, nick, severine.queune |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.03
|
|
Bug Depends on: | 18283 | ||
Bug Blocks: | |||
Attachments: |
Bug 29312: Remove unnecessary point
Bug 29312: Remove unnecessary point Bug 29312: Remove unnecessary dot |
Description
Katrin Fischer
2021-10-24 10:32:34 UTC
Created attachment 132973 [details] [review] Bug 29312: Remove unnecessary point This patch removes an extra point after the number of shown results. Test plan : - don't apply patch - run a report that brings you more than 20 results, e.g. SELECT * FROM biblio LIMIT 50 - see extra ' .' after the number of shown results - apply patch - run the report again and see the point isn't displayed anymore - check the behaviour is still correct when you change the number of rows displayed - sign off ! Created attachment 135458 [details] [review] Bug 29312: Remove unnecessary point This patch removes an extra point after the number of shown results. Test plan : - don't apply patch - run a report that brings you more than 20 results, e.g. SELECT * FROM biblio LIMIT 50 - see extra ' .' after the number of shown results - apply patch - run the report again and see the point isn't displayed anymore - check the behaviour is still correct when you change the number of rows displayed - sign off ! Signed-off-by: David Nind <david@davidnind.com> Nick, extra '.' or extra space? (In reply to Jonathan Druart from comment #3) > Nick, extra '.' or extra space? It looks good without the dot (In reply to Jonathan Druart from comment #3) > Nick, extra '.' or extra space? To me, it's an information not a sentence so dot didn't seem necessary. I can change that if you prefer, though, Jonathan. Created attachment 135503 [details] [review] Bug 29312: Remove unnecessary dot This patch removes an extra point after the number of shown results. Test plan : - don't apply patch - run a report that brings you more than 20 results, e.g. SELECT * FROM biblio LIMIT 50 - see extra ' .' after the number of shown results - apply patch - run the report again and see the point isn't displayed anymore - check the behaviour is still correct when you change the number of rows displayed - sign off ! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Séverine Queune from comment #5) > (In reply to Jonathan Druart from comment #3) > > Nick, extra '.' or extra space? > > To me, it's an information not a sentence so dot didn't seem necessary. > I can change that if you prefer, though, Jonathan. I don't care, I am happy with both :) (In reply to Nick Clemens from comment #4) > (In reply to Jonathan Druart from comment #3) > > Nick, extra '.' or extra space? > > It looks good without the dot Thanks for your quick response! Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.03 |