| Summary: | OverDrive search page should not require edit_borrowers permission | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 29318: Remove permission check from overdrive search page
Bug 29318: Tidy the code Bug 29318: Remove permission check from overdrive search page Bug 29318: Tidy the code Bug 29318: Remove permission check from overdrive search page Bug 29318: Tidy the code |
||
|
Description
Nick Clemens (kidclamp)
2021-10-25 18:45:13 UTC
Created attachment 126840 [details] [review] Bug 29318: Remove permission check from overdrive search page This removes the 'edit_borrowers' permission from OverDrive search To test: 1 - Enable OverDrive via koha system preferences 2 - Sign in to opac with a user with no permissions 3 - Perform a search that will return OD results, 'love' works 4 - Click thje "Found XX results in the library's OverDrive collection" 5 - Note you are logged out of Koha 6 - Apply patch 7 - Repeat 8 - Success Created attachment 126841 [details] [review] Bug 29318: Tidy the code Created attachment 126842 [details] [review] Bug 29318: Remove permission check from overdrive search page This removes the 'edit_borrowers' permission from OverDrive search To test: 1 - Enable OverDrive via koha system preferences 2 - Sign in to opac with a user with no permissions 3 - Perform a search that will return OD results, 'love' works 4 - Click thje "Found XX results in the library's OverDrive collection" 5 - Note you are logged out of Koha 6 - Apply patch 7 - Repeat 8 - Success Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 126843 [details] [review] Bug 29318: Tidy the code Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 126849 [details] [review] Bug 29318: Remove permission check from overdrive search page This removes the 'edit_borrowers' permission from OverDrive search To test: 1 - Enable OverDrive via koha system preferences 2 - Sign in to opac with a user with no permissions 3 - Perform a search that will return OD results, 'love' works 4 - Click thje "Found XX results in the library's OverDrive collection" 5 - Note you are logged out of Koha 6 - Apply patch 7 - Repeat 8 - Success Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 126850 [details] [review] Bug 29318: Tidy the code Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Couldn't test with Overdrive, but trusting Owen has. Code reads well and a permission check definitely makes no sense in an OPAC script. So basically this script has never been used? Pushed to master for 21.11, thanks to everybody involved! |