Bug 29378

Hi Pavel,
there is actually a small mistake in the version that is causing this that will be fixed as soon as possible. Do you have access to your database with SQL?

(In reply to Katrin Fischer from comment #1)
> Hi Pavel,
> there is actually a small mistake in the version that is causing this that
> will be fixed as soon as possible. Do you have access to your database with
> SQL?

Yes, I have.

Ok, the problem is that the version in Koha.pm doesn't match the one in the database because of a forgotten database update. When they both match again, you will get out of the installer loop.

Koha.pm has:
$VERSION = "21.05.05.000";

So this should do the trick:
UPDATE systempreferences SET value = "21.0505000" where variable = "Version";

You might need to restart Plack/Memcached for Koha to take notice.

Did it work alright? Leaving this open as we still need to fix it in Koha.

(In reply to Katrin Fischer from comment #4)
> Did it work alright? Leaving this open as we still need to fix it in Koha.

Yes, thank you very much!

(In reply to Katrin Fischer from comment #4)
> Did it work alright? Leaving this open as we still need to fix it in Koha.

i've pushed a new 21.05.05-2 package, with the database update added

Created attachment 127123 [details] [review]
DBRev 21.05.05.002

hi Kyle,
i've attached a patch, to be added to the 21.05 branch

$DBversion = '21.05.05.002';
Minor mistake in the patch. The 4th part should be zeroed when incrementing the 3rd part for a release.

Example from a past release:
https://git.koha-community.org/Koha-community/Koha/commit/b17cf65633107306bd5d423998a50b65aaecce65

This means the version in DB > version in code:
https://git.koha-community.org/Koha-community/Koha/commit/ba30e76d1a08ef84e66583cd4638f6150ffdeee2

I don't think that should cause issues (though I don't know eventual quirks of version management).

(but it's important for Kyle and Nick to account for that and not fix it by starting from 21.05.05.000 because it's been distributed and ran already)

Created attachment 127125 [details] [review]
DBRev 21.05.05.003

(In reply to Victor Grousset/tuxayo from comment #10)
> (but it's important for Kyle and Nick to account for that and not fix it by
> starting from 21.05.05.000 because it's been distributed and ran already)

i've released a package as 21.05.05.003, so here's the patch for that

(In reply to Mason James from comment #12)
> (In reply to Victor Grousset/tuxayo from comment #10)
> > (but it's important for Kyle and Nick to account for that and not fix it by
> > starting from 21.05.05.000 because it's been distributed and ran already)
> 
> i've released a package as 21.05.05.003, so here's the patch for that

root@deb10:/home/mason# apt-cache policy koha-common
koha-common:
  Installed: 21.05.05-3
  Candidate: 21.05.05-3
  Version table:
 *** 21.05.05-3 500
        500 http://debian.koha-community.org/koha stable/main amd64 Packages
        100 /var/lib/dpkg/status

Victor is right, that it should have been 21.05.05.000, because the 003 suggests 3 database updates in the cycle up to 21.05.05. It usually goes like this:

21.05.04.000 (release of 21.05.04)
21.05.04.001 (first database update for 21.05.05)
21.05.04.002 (second database update for 21.05.05
...
21.05.05.000 (release of 21.05.05 - which was missing here)
21.05.05.001 (first database update for 21.05.06)
...

I guess we could either set back to 21.05.05.000 at the beginning of the cycle now or Kyle will have to start 21.05.05.004 now.

Just trying to explain the misunderstanding and why we need to deal with it now. As the packages are out there, it's too risky not to deal with the unexpected jump.

(In reply to Katrin Fischer from comment #14)
> Victor is right, that it should have been 21.05.05.000, because the 003
> suggests 3 database updates in the cycle up to 21.05.05. 

Argh. This should be: in the cylce up to 21.05.06!

> I guess we could either set back to 21.05.05.000 at the beginning of the cycle now or Kyle will have to start 21.05.05.004 now.

The DB upgrade to 21.05.05.002 has already been released so we can't move it backwards right?
So Kyle should just have to continue from 21.05.05.004

(In reply to Victor Grousset/tuxayo from comment #16)
> > I guess we could either set back to 21.05.05.000 at the beginning of the cycle now or Kyle will have to start 21.05.05.004 now.
> 
> The DB upgrade to 21.05.05.002 has already been released so we can't move it
> backwards right?
> So Kyle should just have to continue from 21.05.05.004

You are probably right about continuing with 21.05.05.004. Maybe there won't even be a database update this cycle so we can jump to 21.05.06.000 next.

(In reply to Katrin Fischer from comment #17)
> (In reply to Victor Grousset/tuxayo from comment #16)
> > > I guess we could either set back to 21.05.05.000 at the beginning of the cycle now or Kyle will have to start 21.05.05.004 now.
> > 
> > The DB upgrade to 21.05.05.002 has already been released so we can't move it
> > backwards right?
> > So Kyle should just have to continue from 21.05.05.004
> 
> You are probably right about continuing with 21.05.05.004. Maybe there won't
> even be a database update this cycle so we can jump to 21.05.06.000 next.

yes, i think Katrin is correct :)

I see this is actually in 21.05.x :
https://git.koha-community.org/Koha-community/Koha/commit/1b39d0717a4b81cda28c72e07bb47e534d9d205b

And there is a DBRev 21.05.05.004 for Bug 29386

So problem solved ?

(In reply to Fridolin Somers from comment #19)
> I see this is actually in 21.05.x :
> https://git.koha-community.org/Koha-community/Koha/commit/
> 1b39d0717a4b81cda28c72e07bb47e534d9d205b
> 
> And there is a DBRev 21.05.05.004 for Bug 29386
> 
> So problem solved ?

i think yes, we can close the bug