Summary: | Debug mode not honoured in SMTP transport | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrewfh, jonathan.druart, kyle, liz, martin.renvoize, nick, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
The debug flag on the SMTP servers configuration was not being used correctly. This patch implements the expected behavior.
Note: Enabling this will lead to lots of logging for each SMTP connection Koha does.
|
Version(s) released in: |
21.11.00,21.05.08
|
Bug Depends on: | 22343 | ||
Bug Blocks: | |||
Attachments: |
Bug 29427: Regression tests
Bug 29427: Make SMTP transport set debug mode correctly Bug 29427: Regression tests Bug 29427: Make SMTP transport set debug mode correctly Bug 29427: Regression tests Bug 29427: Make SMTP transport set debug mode correctly |
Description
Tomás Cohen Arazi
2021-11-05 15:46:01 UTC
Created attachment 127397 [details] [review] Bug 29427: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 127398 [details] [review] Bug 29427: Make SMTP transport set debug mode correctly This patch makes the _transport_ method in Koha::SMTP::Server pass the debug flag correctly to the Email::Sender::Transport::SMTP->new constructor. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => FAIL: Oh noes! debug is not passed to the constructor! 3. Apply this patch 4. Repeat 2 => SUCCESS: Hey! It is being set! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 127402 [details] [review] Bug 29427: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 127403 [details] [review] Bug 29427: Make SMTP transport set debug mode correctly This patch makes the _transport_ method in Koha::SMTP::Server pass the debug flag correctly to the Email::Sender::Transport::SMTP->new constructor. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => FAIL: Oh noes! debug is not passed to the constructor! 3. Apply this patch 4. Repeat 2 => SUCCESS: Hey! It is being set! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 127427 [details] [review] Bug 29427: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 127428 [details] [review] Bug 29427: Make SMTP transport set debug mode correctly This patch makes the _transport_ method in Koha::SMTP::Server pass the debug flag correctly to the Email::Sender::Transport::SMTP->new constructor. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => FAIL: Oh noes! debug is not passed to the constructor! 3. Apply this patch 4. Repeat 2 => SUCCESS: Hey! It is being set! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial fix, works as expected.. Passing QA Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.08 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |