Summary: | Table cell click doesn't activate buttons in patron search | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Patrons | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
Severity: | normal | ||
Priority: | P5 - low | CC: | barbara.johnson, gmcharlt, joonas.kylmala, kyle.m.hall, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00
|
Circulation function: | |
Bug Depends on: | 15812 | ||
Bug Blocks: | |||
Attachments: |
Bug 29430: Table cell click doesn't activate buttons in patron search
Bug 29430: Table cell click doesn't activate buttons in patron search Bug 29430: Table cell click doesn't activate buttons in patron search |
Description
Owen Leonard
2021-11-05 18:17:12 UTC
Created attachment 127401 [details] [review] Bug 29430: Table cell click doesn't activate buttons in patron search Bug 15812 included a change which allows a click on the patron search results table cell to toggle the checkbox it contains. This patch modifies that click event so that it fires the change() event which is required for toggling the "Add to patron list" and "Merge patrons" buttons. To reproduce this problem, perform a patron search in the staff client which will return multiple results. - In the first column containing checkboxes, click in the empty part of the table cell. The checkbox should be checked. - However, the "Add to patron list" button remains disabled. - Clicking a table cell to check another checkbox should result in the "Merge selected patrons" button being enabled, but it doesn't. To test, apply the patch and repeat the process above. The behavior of the buttons should be the same whether you're clicking the checkbox itself or the table cell it's in. Created attachment 127407 [details] [review] Bug 29430: Table cell click doesn't activate buttons in patron search Bug 15812 included a change which allows a click on the patron search results table cell to toggle the checkbox it contains. This patch modifies that click event so that it fires the change() event which is required for toggling the "Add to patron list" and "Merge patrons" buttons. To reproduce this problem, perform a patron search in the staff client which will return multiple results. - In the first column containing checkboxes, click in the empty part of the table cell. The checkbox should be checked. - However, the "Add to patron list" button remains disabled. - Clicking a table cell to check another checkbox should result in the "Merge selected patrons" button being enabled, but it doesn't. To test, apply the patch and repeat the process above. The behavior of the buttons should be the same whether you're clicking the checkbox itself or the table cell it's in. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 127412 [details] [review] Bug 29430: Table cell click doesn't activate buttons in patron search Bug 15812 included a change which allows a click on the patron search results table cell to toggle the checkbox it contains. This patch modifies that click event so that it fires the change() event which is required for toggling the "Add to patron list" and "Merge patrons" buttons. To reproduce this problem, perform a patron search in the staff client which will return multiple results. - In the first column containing checkboxes, click in the empty part of the table cell. The checkbox should be checked. - However, the "Add to patron list" button remains disabled. - Clicking a table cell to check another checkbox should result in the "Merge selected patrons" button being enabled, but it doesn't. To test, apply the patch and repeat the process above. The behavior of the buttons should be the same whether you're clicking the checkbox itself or the table cell it's in. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Pushed to master for 21.11, thanks to everybody involved! |