Bug 29435

Summary:	OPAC authority details page broken when AuthDisplayHierarchy is enabled
Product:	Koha	Reporter:	Andreas Roussos <a.roussos>
Component:	MARC Authority data support	Assignee:	Andreas Roussos <a.roussos>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	dcook, jonathan.druart, kyle, nick
Version:	Main
Hardware:	All
OS:	All
URL:	opac/opac-authoritiesdetail.pl
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	21.11.00
Circulation function:
Bug Depends on:	17600
Bug Blocks:	11873
Attachments:	Bug 29435: include missing subroutine from C4::AuthoritiesMarc Bug 29435: include missing subroutine from C4::AuthoritiesMarc Bug 29435: include missing subroutine from C4::AuthoritiesMarc

Description Andreas Roussos 2021-11-08 08:26:43 UTC

When the 'AuthDisplayHierarchy' System Preference is set to 'Enable',
the OPAC authority details page is broken and the following message
appears in the logs:

Undefined subroutine GenerateHierarchy called at opac-authoritiesdetail.pl line 83

Comment 1 Andreas Roussos 2021-11-08 08:35:18 UTC

Created attachment 127426 [details] [review]
Bug 29435: include missing subroutine from C4::AuthoritiesMarc

The OPAC authority details page is broken when the 'AuthDisplayHierarchy'
System Preference is set to 'Enable',

This patch fixes that.

Test plan:
1) Set AuthDisplayHierarchy to 'Enable' and try to view the details
   page of an authority in the OPAC -- the page is broken.
2) Apply this patch.
3) Refresh the page; this time the authority details are displayed.

Comment 2 David Nind 2021-11-08 11:48:38 UTC

Created attachment 127440 [details] [review]
Bug 29435: include missing subroutine from C4::AuthoritiesMarc

The OPAC authority details page is broken when the 'AuthDisplayHierarchy'
System Preference is set to 'Enable',

This patch fixes that.

Test plan:
1) Set AuthDisplayHierarchy to 'Enable' and try to view the details
   page of an authority in the OPAC -- the page is broken.
2) Apply this patch.
3) Refresh the page; this time the authority details are displayed.

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Nick Clemens (kidclamp) 2021-11-10 12:51:59 UTC

Created attachment 127510 [details] [review]
Bug 29435: include missing subroutine from C4::AuthoritiesMarc

The OPAC authority details page is broken when the 'AuthDisplayHierarchy'
System Preference is set to 'Enable',

This patch fixes that.

Test plan:
1) Set AuthDisplayHierarchy to 'Enable' and try to view the details
   page of an authority in the OPAC -- the page is broken.
2) Apply this patch.
3) Refresh the page; this time the authority details are displayed.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 4 Jonathan Druart 2021-11-15 11:40:32 UTC

Pushed to master for 21.11, thanks to everybody involved!