| Summary: | Show userid on "your personal details" tab | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | OPAC | Assignee: | Magnus Enger <magnus> |
| Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, kyle, Laura.escamilla, lucas, m.de.rooy, matt.blenkinsop |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
Patrons can now see their username in the 'Personal details' tab in the OPAC.
This can be hidden from them using the PatronSelfModificationBorrowerUnwantedField system preference, if needed.
|
Version(s) released in: |
23.05.00
|
| Circulation function: | |||
| Attachments: |
Bug 29449: Show userid on "Personal details" tab
Bug 29449: Show userid on "Personal details" tab Bug 29449: Show userid on "Personal details" tab Bug 29449: Show userid on "Personal details" tab Bug 29449: Show userid on "Personal details" tab |
||
|
Description
Magnus Enger
2021-11-10 10:11:38 UTC
We already have the "*unwanted*" prefs for the OPAC and they also already list userid, but it's not displayed according to it, like you say. I'd almost say that this is a bug? Created attachment 147114 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Sign off Works as described but when a patron self registers there is now an empty 'Username:' Should we check to see if the action is 'edit' or not so that will not appear on the self registration form? (In reply to Lucas Gass from comment #3) > Works as described but when a patron self registers there is now an empty > 'Username:' > > Should we check to see if the action is 'edit' or not so that will not > appear on the self registration form? Gah! I thought I checked that! It makes perfect sense of course. New patch coming. Created attachment 147195 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off https://bugs.koha-community.org/show_bug.cgi?id=32922 Created attachment 147196 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off (In reply to Magnus Enger from comment #6) > Created attachment 147196 [details] [review] [review] > Bug 29449: Show userid on "Personal details" tab > > To reproduce: > - Login to the OPAC > - Go to the "Personal details" tab > - Verify the Username/userid of the logged in user is not > shown anywhere > > To test: > - Apply this patch > - Reload the "Personal details" tab > - Verify that "Username:" and the userid is now shown below the > "Library card number" > - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField > and verify the field is hidden as expected > - Log out > - Go to "Don't have an account? Register here." > - Verify "Username:" is *not* shown > - Sign off Signed-Off-By: Laura Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 147975 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 148687 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Interesting! I have a question: What would be the recommended way to use this in relation to the various borrower mandatory/unwanted settings? I applied this change on 21.11 and still did not see userid. Enhancement - not backporting to 22.11.x Nice work everyone! Seems like a bug fix. Nothing to add/amend in the manual. |